Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WFLY-19592 MicroProfile Fault Tolerance 4.1 #649

Merged
merged 4 commits into from
Dec 10, 2024
Merged

WFLY-19592 MicroProfile Fault Tolerance 4.1 #649

merged 4 commits into from
Dec 10, 2024

Conversation

rhusar
Copy link
Member

@rhusar rhusar commented Oct 21, 2024 •
edited
Loading

@github-actions github-actions bot added the stability-level/default "Default" stability-level label Oct 21, 2024
fabiobrz
fabiobrz suggested changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@fabiobrz fabiobrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this proposal @rhusar - great to see it follows the latest template, BTW.
I've asked some questions and dropped comments, feel free to let me know what you think.

microprofile/WFLY-19592_MicroProfile_Fault_Tolerance_4_1.adoc Show resolved Hide resolved
microprofile/WFLY-19592_MicroProfile_Fault_Tolerance_4_1.adoc Outdated Show resolved Hide resolved
microprofile/WFLY-19592_MicroProfile_Fault_Tolerance_4_1.adoc Outdated Show resolved Hide resolved
microprofile/WFLY-19592_MicroProfile_Fault_Tolerance_4_1.adoc Show resolved Hide resolved
microprofile/WFLY-19592_MicroProfile_Fault_Tolerance_4_1.adoc Outdated Show resolved Hide resolved
microprofile/WFLY-19592_MicroProfile_Fault_Tolerance_4_1.adoc Show resolved Hide resolved
microprofile/WFLY-19592_MicroProfile_Fault_Tolerance_4_1.adoc Show resolved Hide resolved
microprofile/WFLY-19592_MicroProfile_Fault_Tolerance_4_1.adoc Outdated Show resolved Hide resolved
microprofile/WFLY-19592_MicroProfile_Fault_Tolerance_4_1.adoc Show resolved Hide resolved
microprofile/WFLY-19592_MicroProfile_Fault_Tolerance_4_1.adoc Show resolved Hide resolved
@rhusar rhusar changed the title WFLY-19592 [MP Platform 7] MicroProfile Fault Tolerance 4.1 WFLY-19592 MicroProfile Fault Tolerance 4.1 Oct 22, 2024
@github-actions github-actions bot added stability-level/default "Default" stability-level and removed stability-level/default "Default" stability-level labels Oct 22, 2024
@github-actions github-actions bot added stability-level/default "Default" stability-level and removed stability-level/default "Default" stability-level labels Oct 23, 2024
fabiobrz
fabiobrz approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@fabiobrz fabiobrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rhusar - LGTM, approving from QA perspective.

@github-actions github-actions bot added stability-level/default "Default" stability-level and removed stability-level/default "Default" stability-level labels Oct 30, 2024
@rhusar
Copy link
Member Author

rhusar commented Oct 30, 2024

Thanks @rhusar - LGTM, approving from QA perspective.

Thanks for the review, PS: I added information about manual testing.

@github-actions github-actions bot added stability-level/default "Default" stability-level and removed stability-level/default "Default" stability-level labels Oct 31, 2024
@github-actions github-actions bot added stability-level/default "Default" stability-level and removed stability-level/default "Default" stability-level labels Nov 13, 2024
@github-actions github-actions bot added stability-level/default "Default" stability-level and removed stability-level/default "Default" stability-level labels Nov 14, 2024
@github-actions github-actions bot removed the stability-level/default "Default" stability-level label Nov 21, 2024
@github-actions github-actions bot added the stability-level/default "Default" stability-level label Nov 21, 2024
rhusar and others added 4 commits December 4, 2024 10:08
@rhusar
WFLY-19592 MicroProfile Fault Tolerance 4.1
727ae40
@rhusar @fabiobrz
Update microprofile/WFLY-19592_MicroProfile_Fault_Tolerance_4_1.adoc
3905bc1 
Co-authored-by: Fabio Burzigotti <34456377+fabiobrz@users.noreply.github.com>
@rhusar @fabiobrz
Update microprofile/WFLY-19592_MicroProfile_Fault_Tolerance_4_1.adoc
fd1c063 
Co-authored-by: Fabio Burzigotti <34456377+fabiobrz@users.noreply.github.com>
@rhusar
WFLY-19592 Define Telemetry and Micrometer metrics in the MicroProfil…
26bb44b 
…e Fault Tolerance 4.1 upgrade.
@github-actions github-actions bot added stability-level/default "Default" stability-level and removed stability-level/default "Default" stability-level labels Dec 4, 2024
@darranl darranl merged commit 2a4de23 into wildfly:main Dec 10, 2024
1 check passed
@rhusar rhusar deleted the WFLY-19592 branch December 11, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiobrz fabiobrz fabiobrz approved these changes

@bstansberry bstansberry bstansberry left review comments

@jasondlee jasondlee jasondlee left review comments

@kabir kabir kabir left review comments

Assignees
No one assigned
Labels
stability-level/default "Default" stability-level
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MP Platform 7] MicroProfile Fault Tolerance 4.1
6 participants
@rhusar @kabir @jasondlee @bstansberry @fabiobrz @darranl