Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spring cleaning #74

Merged
merged 8 commits into from
Nov 20, 2024
Merged

Spring cleaning #74

merged 8 commits into from
Nov 20, 2024

Conversation

delucis
Copy link
Member

@delucis delucis commented Nov 20, 2024 •
edited
Loading

  • Update dependencies
  • Remove tsc from linting steps now astro check covers that
  • Switch to hybrid rendering (same behaviour as before, just one prerender = false instead of four prerender = true)

@netlify Netlify
Copy link

netlify bot commented Nov 20, 2024 •
edited
Loading

✅ Deploy Preview for astro-new ready!

Name Link
🔨 Latest commit f4b3785
🔍 Latest deploy log https://app.netlify.com/sites/astro-new/deploys/673e6a8e7e78e50008f531e8
😎 Deploy Preview https://deploy-preview-74--astro-new.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@delucis delucis changed the title WIP Spring cleaning Nov 20, 2024
@delucis delucis marked this pull request as ready for review November 20, 2024 23:22
sarah11918
sarah11918 approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @delucis ! Tested the deploy preview on Chrome/ChromeOS and all looks good on my end!

@delucis delucis merged commit aa9bf7c into main Nov 20, 2024
5 checks passed
@delucis delucis deleted the chris/lessgo branch November 20, 2024 23:33
@delucis delucis mentioned this pull request Nov 21, 2024
Merged
delucis added a commit that referenced this pull request Nov 21, 2024
@delucis
Align auto-format GitHub workflow with changes in #74
97539ef
delucis added a commit that referenced this pull request Nov 21, 2024
@delucis
Align lint GitHub workflow with changes in #74
eb2065e
delucis added a commit that referenced this pull request Nov 21, 2024
@delucis
Update GitHub workflows to match changes from #74 (#76)
a3b83ee 
* Align auto-format GitHub workflow with changes in #74

* Align lint GitHub workflow with changes in #74

* Use Node version from `.nvmrc` instead of duplicating
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delucis @sarah11918