Docs: update code snippet to deploy to github #4969
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
If this PR can be merged, I can update this code snippet in the other languages. |
There was a problem hiding this comment.
Thank you for submitting this, @torn4dom4n ! I made a small editing suggestion for some wording, and I will also be adding the "needs confirmation" label so that someone else can also test the new instructions for confirmation.
We'll try to get someone to verify the commands as soon as we can! 🙌
sarah11918
added
help - confirm behaviour
|
@sarah11918 I can wait for it. Let me know if anything needs to be changed. |
|
@sarah11918 I used my snippet in my project and everything is fine. Although that, we should merge this PR after withastro/action#29 is merged. |
|
Thanks for the update, @torn4dom4n ! If this should wait for the other PR, then I'm going to add a label so that it doesn't get merged before that PR! 🙌 |
sarah11918
added
merge-on-release
sarah11918
removed
the
help - confirm behaviour
|
Hi @torn4dom4n ! It doesn't seem like anyone is working on withastro/action#29 , so I think we should close this Docs PR if it can't be merged before that one. PRs that sit open while the rest of the docs site constantly updates can lead to conflicts, especially as we are getting close to moving this entire site over to Starlight. We're going to have a lot of changing files and moving pieces, and every extra bit of "unfinished business" will make migrating more difficult. You can reopen the again, or make a new one, when there is a resolution to the other PR! Thank you for understanding! |
|
@sarah11918 I got it. When everything is ready, I'll reopen a new PR. |
Description (required)
Update code snippet to deploy to GitHub Pages.
Related issues & labels (optional)
Suggested label:
code-snippet-update,improve-document,hacktoberfest-accepted