(#275) Allow users to change username when editing profile #279
Conversation
core/forms.py
Outdated
| @@ -290,5 +290,5 @@ class UserAdminForm(CaseInsensitiveUsernameMixin, ContribUserChangeForm): | |||
| expo_notif_tokens = forms.JSONField(required=False) | |||
|
|
|||
|
|
|||
| class UserCreationForm(CaseInsensitiveUsernameMixin, ContribUserCreationForm): | |||
| class UserCreationForm(CaseInsensitiveUsernameMixin, ContribAdminUserCreationForm): | |||
There was a problem hiding this comment.
Sorry why does this need to be ADMIN user form?
There was a problem hiding this comment.
core.UserCreationForm requires the same priveleges as django's AdminPasswordChangeForm (specific password-related form mixins) because passwords have to be dealt with when making a new user. I could either manually add the mixins to core.UserCreationForm or use django's AdminUserCreationForm (what I did above) which is almost identical to the normal UserCreationForm except for the fact that it comes with the mixins already.
There was a problem hiding this comment.
core.UserCreationForm is only ever used in core.UserAdmin anyways
There was a problem hiding this comment.
I think it might be better to rename core.UserCreationForm to core.UserCreationAdminForm in order to stay consistent. If you look inside admin.py:
from .forms import (
AnnouncementAdminForm,
AnnouncementSupervisorAdminForm,
EventAdminForm,
OrganizationAdminForm,
TagAdminForm,
TagSuperuserAdminForm,
TermAdminForm,
UserAdminForm,
UserCreationForm, # Not named as an admin form (?)
)There was a problem hiding this comment.
If that's the case then yeah, it should be
#275
also fixed a bug where the form for creating a new user in admin panel could not be loaded