Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for negative number as well as zero for vector product (#Issue 6) #20

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

ahiliitb
Copy link

@ahiliitb ahiliitb commented Oct 18, 2024

#6

@ahiliitb ahiliitb changed the title added support for negative number as well as zero added support for negative number as well as zero for vector product (#Issue 6) Oct 18, 2024
@LoPA607
Copy link
Contributor

LoPA607 commented Oct 19, 2024

Hi ,
Good to see your enthu to solve problems but
There is a small issue in your code
log_correct.cpp: In function ‘std::pair<int, int> count_negative_and_zero(int*, int, int)’:
log_correct.cpp:29:78: error: ‘negative_count’ appears more than once in data clauses
29 | #pragma omp parallel for private(negative_count, zero_count) reduction(+:negative_count, zero_count) num_threads(num_threads)
| ^~~~~~~~~~~~~~
log_correct.cpp:29:94: error: ‘zero_count’ appears more than once in data clauses
29 | #pragma omp parallel for private(negative_count, zero_count) reduction(+:negative_count, zero_count) num_threads(num_threads)
please rectify it .

@LoPA607 LoPA607 merged commit c46c3c2 into wncc:main Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants