Expose shared CalendarType type #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtekmaj
approved these changes
Aug 5, 2024
|
@wojtekmaj I'm sorry to bother you but is there any chance you could cut a release for this change? |
|
It's out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! 👋
Firstly, thanks so much for your work on this package! I should probably have opened an issue about this but given it's such a small change I opted for a PR, apologies if that's not the done thing. We can close and take this to an issue if you prefer.
We have need of CalendarType in the grafana codebase here. However I'm not a fan of these nested imports which, if we were to migrate to Vite, I'm pretty sure will fail as the file shared/types is not exported.
This PR simply adds the type we're using to the exports in index.ts to save us from accessing types that aren't (currently) public.