Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deleting a site by a slug that is an integer #444

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Fix deleting a site by a slug that is an integer #444

merged 1 commit into from
Nov 16, 2023

Conversation

shawnhooper
Copy link
Contributor

Fixes: #441

Calls get_id_from_blogname to look up the slug before calling get_blog_details. This lookup works with slugs that are made up of strings or integers.

@shawnhooper shawnhooper requested a review from a team as a code owner November 14, 2023 20:51
@swissspidy swissspidy added this to the 2.5.7 milestone Nov 15, 2023
@swissspidy swissspidy merged commit 3f7c916 into wp-cli:main Nov 16, 2023
36 checks passed
@danielbachhuber danielbachhuber mentioned this pull request Nov 16, 2023
Merged
@shawnhooper shawnhooper deleted the 441-delete-site-by-slug branch November 16, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.

--slug= option of wp site delete works wrong for numeric paths
2 participants
@shawnhooper @swissspidy