Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom url redirection issue #6222

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sandushi
Copy link
Contributor

Purpose

  • To fix the issue of not redirecting to configured custom urls
  • When the tenant qualified urls are enabled, the configured custom urls are not honored.
  • To fix that issue, we introduced v2 configurations to add the custom urls and when tenant qualified urls config is enabled, we checked on the v2 cobfigurations and redirect to those configured urls.
  • The customers needs to add the customized urls inside the v2 authentication endpoints.
[authentication.endpoints.v2]
login_url= "<URL>"
retry_url= "<URL>"

Related issue

wso2/product-is#21458

Reference PR

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12396239438

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 4.65116% with 82 lines in your changes missing coverage. Please review.

Project coverage is 45.55%. Comparing base (f721c11) to head (9a19417).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
.../config/builder/FileBasedConfigurationBuilder.java 0.00% 69 Missing ⚠️
...tication/framework/config/ConfigurationFacade.java 23.52% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6222      +/-   ##
============================================
- Coverage     45.56%   45.55%   -0.02%     
+ Complexity    14147    14041     -106     
============================================
  Files          1632     1631       -1     
  Lines        102355   101863     -492     
  Branches      17677    17774      +97     
============================================
- Hits          46640    46401     -239     
+ Misses        48954    48729     -225     
+ Partials       6761     6733      -28     
Flag Coverage Δ
unit 28.27% <4.65%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12396239438
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12396239438

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants