Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce JDBC based persistence for SAML #6241

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Introduce JDBC based persistence for SAML #6241

wants to merge 1 commit into from

Conversation

Osara-B
Copy link
Contributor

@Osara-B Osara-B commented Dec 20, 2024 •
edited by darshanasbg
Loading

Proposed changes in this pull request

Introduce JDBC based persistence for SAML. Related to,

@codecov Codecov
Copy link

codecov bot commented Dec 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 79.64989% with 93 lines in your changes missing coverage. Please review.

Project coverage is 45.87%. Comparing base (7c68916) to head (d1e67ce).
Report is 18 commits behind head on master.

Files with missing lines Patch % Lines
...ty/core/dao/JDBCSAMLSSOServiceProviderDAOImpl.java 86.20% 30 Missing and 14 partials ⚠️
.../identity/core/model/SAMLSSOServiceProviderDO.java 61.53% 3 Missing and 32 partials ⚠️
...ore/dao/RegistrySAMLSSOServiceProviderDAOImpl.java 44.00% 7 Missing and 7 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #6241      +/-   ##
============================================
+ Coverage     45.71%   45.87%   +0.16%     
- Complexity    14091    14183      +92     
============================================
  Files          1633     1636       +3     
  Lines        100857   101284     +427     
  Branches      17723    17781      +58     
============================================
+ Hits          46104    46462     +358     
- Misses        48035    48059      +24     
- Partials       6718     6763      +45
Flag Coverage Δ
unit 28.69% <79.64%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@darshanasbg darshanasbg changed the title Introduce SAMLSSOPersistenceManagerFactory and JDBC based persistence for SAML Introduce JDBC based persistence for SAML Dec 21, 2024
UdeshAthukorala
UdeshAthukorala reviewed Dec 22, 2024
View reviewed changes
....core/src/main/java/org/wso2/carbon/identity/core/dao/JDBCSAMLSSOServiceProviderDAOImpl.java Show resolved Hide resolved
....core/src/main/java/org/wso2/carbon/identity/core/dao/JDBCSAMLSSOServiceProviderDAOImpl.java Outdated Show resolved Hide resolved
....core/src/main/java/org/wso2/carbon/identity/core/dao/JDBCSAMLSSOServiceProviderDAOImpl.java Outdated Show resolved Hide resolved
....core/src/main/java/org/wso2/carbon/identity/core/dao/JDBCSAMLSSOServiceProviderDAOImpl.java Outdated Show resolved Hide resolved
...ty.core/src/main/java/org/wso2/carbon/identity/core/dao/SAMLSSOServiceProviderConstants.java Outdated Show resolved Hide resolved
...carbon.identity.core/src/test/java/org/wso2/carbon/identity/core/constant/TestConstants.java Show resolved Hide resolved
...rg.wso2.carbon.identity.core/src/test/java/org/wso2/carbon/identity/core/util/TestUtils.java Show resolved Hide resolved
...rg.wso2.carbon.identity.core/src/test/java/org/wso2/carbon/identity/core/util/TestUtils.java Outdated Show resolved Hide resolved
...es/identity-core/org.wso2.carbon.identity.core.server.feature/resources/dbscripts/oracle.sql Outdated Show resolved Hide resolved
...es/identity-core/org.wso2.carbon.identity.core.server.feature/resources/dbscripts/oracle.sql Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5.2% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UdeshAthukorala UdeshAthukorala UdeshAthukorala left review comments

@darshanasbg darshanasbg darshanasbg left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Osara-B @darshanasbg @UdeshAthukorala