Remove a lot of legacy build logic and simplify remaining logic. #21745

rolfbjarne · 2024-12-03T13:11:28Z

Remove lots of legacy build logic.
When building native bits, put them in ".libs/<runtimeidentifier>" as
opposed to ".libs/<not quite runtimeidentifier>", because it simplifies a
lot of logic.

* Remove lots of legacy build logic. * When building native bits, put them in ".libs/<runtimeidentifier>" as opposed to ".libs/<not quite runtimeidentifier>", because it simplifies a lot of logic.

mcumming · 2024-12-06T19:21:41Z

When building native bits, put them in ".libs/" as
opposed to ".libs/"

Not exactly positive on the difference here.

…lation-cleanup

vs-mobiletools-engineering-service2 · 2024-12-10T09:13:23Z

✅ [CI Build] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 4a5502763fefbc252936adf6d2716ac8b35eaa99 [PR build]

vs-mobiletools-engineering-service2 · 2024-12-10T09:40:38Z

✅ [CI Build] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 4a5502763fefbc252936adf6d2716ac8b35eaa99 [PR build]

vs-mobiletools-engineering-service2 · 2024-12-10T09:41:47Z

✅ [CI Build] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 4a5502763fefbc252936adf6d2716ac8b35eaa99 [PR build]

vs-mobiletools-engineering-service2 · 2024-12-10T09:54:19Z

✅ API diff for current PR / commit

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

✅ API diff vs stable

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 4a5502763fefbc252936adf6d2716ac8b35eaa99 [PR build]

vs-mobiletools-engineering-service2 · 2024-12-10T09:54:46Z

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 4a5502763fefbc252936adf6d2716ac8b35eaa99 [PR build]

vs-mobiletools-engineering-service2 · 2024-12-10T09:55:46Z

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 4a5502763fefbc252936adf6d2716ac8b35eaa99 [PR build]

vs-mobiletools-engineering-service2 · 2024-12-10T09:56:18Z

💻 [CI Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 4a5502763fefbc252936adf6d2716ac8b35eaa99 [PR build]

vs-mobiletools-engineering-service2 · 2024-12-10T09:56:21Z

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 4a5502763fefbc252936adf6d2716ac8b35eaa99 [PR build]

vs-mobiletools-engineering-service2 · 2024-12-10T10:11:35Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 4a5502763fefbc252936adf6d2716ac8b35eaa99 [PR build]

vs-mobiletools-engineering-service2 · 2024-12-10T13:02:47Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 109 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 40 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 7 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 10 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (tvOS): All 9 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 4a5502763fefbc252936adf6d2716ac8b35eaa99 [PR build]

This comment has been minimized.

Sign in to view

rolfbjarne force-pushed the dev/rolf/native-compilation-cleanup branch from 24ca657 to f9e64d0 Compare December 5, 2024 10:46

Remove a lot of legacy build logic and simplify remaining logic.

8442f6f

* Remove lots of legacy build logic. * When building native bits, put them in ".libs/<runtimeidentifier>" as opposed to ".libs/<not quite runtimeidentifier>", because it simplifies a lot of logic.

rolfbjarne force-pushed the dev/rolf/native-compilation-cleanup branch from f9e64d0 to 8442f6f Compare December 6, 2024 18:58

This comment has been minimized.

Sign in to view

Merge remote-tracking branch 'origin/main' into dev/rolf/native-compi…

1dbef2d

…lation-cleanup

This comment has been minimized.

Sign in to view

rolfbjarne mentioned this pull request Dec 10, 2024

[registrar] Fix registration of stub Objective-C classes. Fixes #21546. #21593

Merged

rolfbjarne added 2 commits December 10, 2024 09:34

Remove debug code.

9255da3

Merge remote-tracking branch 'origin/main' into dev/rolf/native-compi…

4a55027

…lation-cleanup

This comment has been minimized.

Sign in to view

rolfbjarne marked this pull request as ready for review December 10, 2024 14:08

dalexsoto approved these changes Dec 11, 2024

View reviewed changes

rolfbjarne merged commit a5ea108 into main Dec 11, 2024
17 checks passed

rolfbjarne deleted the dev/rolf/native-compilation-cleanup branch December 11, 2024 16:44

Remove a lot of legacy build logic and simplify remaining logic. #21745

Remove a lot of legacy build logic and simplify remaining logic. #21745

Conversation

rolfbjarne commented Dec 3, 2024 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

mcumming commented Dec 6, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Dec 10, 2024

✅ [CI Build] Build passed (Detect API changes) ✅

vs-mobiletools-engineering-service2 commented Dec 10, 2024

✅ [CI Build] Build passed (Build packages) ✅

vs-mobiletools-engineering-service2 commented Dec 10, 2024

✅ [CI Build] Build passed (Build macOS tests) ✅

vs-mobiletools-engineering-service2 commented Dec 10, 2024

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

vs-mobiletools-engineering-service2 commented Dec 10, 2024

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

vs-mobiletools-engineering-service2 commented Dec 10, 2024

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

vs-mobiletools-engineering-service2 commented Dec 10, 2024

💻 [CI Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

vs-mobiletools-engineering-service2 commented Dec 10, 2024

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

vs-mobiletools-engineering-service2 commented Dec 10, 2024

💻 [CI Build] Windows Integration Tests passed 💻

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Dec 10, 2024

🚀 [CI Build] Test results 🚀

Test results

Tests counts

rolfbjarne commented Dec 3, 2024 •

edited

Loading