-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a toggle to skip email validation #97
Conversation
@xhit Quick question. I saw that you were using If we use |
@meain Not all addresses in the message are populated by default, the BCC for example, are added to recipients for the |
Hmm, I see. Would you be open to changing it to accepting the full address. Would it cause issues? |
I can't, RCPT only receives the address, not full address. |
e32cc68
to
5c82197
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #97 +/- ##
==========================================
+ Coverage 52.51% 52.65% +0.14%
==========================================
Files 7 7
Lines 1293 1297 +4
==========================================
+ Hits 679 683 +4
Misses 545 545
Partials 69 69
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@xhit Following our discussion, I've added a note in the readme and rebased the code on latest master. Let me know if you need anything else from the PR. |
@meain sorry, I'm currently on vacations, I will tag a new version after that, you can use master branch. Thanks! |
Thanks @xhit. No rush on the tag :D |
This PR adds an option
UseProvidedAddress
which when set directly uses the email provided by the user without validating or trying to parse out its components.Closes #95