-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding verify command #387
base: master
Are you sure you want to change the base?
Conversation
@TheLocehiliosan hi are you still dealing with personal stuff? |
I've reviewed this PR, and I've a few comments. First, I don't think that "verify" is the most descriptive command we could use here. Seeing as the command just outputs the requested value, perhaps "echo" would work? Also, perhaps the value itself could be the simple parameter (without the For example:
Next, it could be nice to output ALL the values, if none are specified (for example just running For a while I was also torn about implementing an additional command instead of extending the "introspect" command that already exists. For example, I could see adding However, the more I've thought about it, I do want "introspect" to remain focused on outputting details of the yadm program, not the user's environment (I realize But I would imagine something like this:
|
Excellent ill get to work on those changes as soon as i have a chance! thanks for reviewing |
just realised that we cant use echo given the cirrent system as echo is a bash keyword, cant name the function echo. |
Then the function can be called |
@TheLocehiliosan ive integrated the requested changes again, im new to writing bash scripting so if there is a better what to do things let me know. hopefully these are better for you |
This is a much better solution than what I came up with I'll implement this in a sec |
Having spent a few days 'playing' with yadm, I have to say I would very much welcome this being merged rather than consulting https://yadm.io/docs/alternates# each time :) |
Damn, I forgot about this, uh, sure! I use home-manager now tho |
What does this PR do?
This addition adds the functionality to query local internal yadm commands for the purposes of creating alt files easier.
What issues does this PR fix or reference?
#360
Previous Behavior
There is not previous behavior for this addition
New Behavior
-o/-os : echos the operating system
-d/-distro: echos the distro
-u/-user: echos the user
-c/-class: echos the class
-h/-host: echos the hostname
Have tests been written for this change?
No
Have these commits been signed with GnuPG?
No
Please review yadm's Contributing Guide for best practices.