Add config for yadm to create read-only template output #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A slight bump on this PR: are there any more blockers for merging this PR? |
|
I adjusted this PR to target the develop branch. Can tests and updates to the manpage be added? |
|
Hi @TheLocehiliosan ! Man and tests had been added! |
|
@soraxas - I updated the pull request to target the develop branch, but there are conflicts. Can you rebase your branch to be on top of the develop branch? |
Signed-off-by: Tin Lai <oscar@tinyiu.com>
Signed-off-by: Tin Lai <oscar@tinyiu.com>
Signed-off-by: Tin Lai <oscar@tinyiu.com>
|
@TheLocehiliosan A slight bump on this PR again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allow user to tell
yadmto create read-only template outputWhat issues does this PR fix or reference?
I always forget that the file I'm editing is an output from
yadmtemplate :( and loss my editing. (despite already adding a header notice on the top of the file)Config via:
$ yadm config yadm.template-read-only truePrevious Behavior
yadmcopies permsNew Behavior
yadmcopies perms, and optionally, remove write permsHave [tests][1] been written for this change?
No
Have these commits been [signed with GnuPG][2]?
Yes
P.S.
This is a global control.
An alternative solution, that allows per-file controls, is to allow template file to have some extra parameters, e.g.,
my_config.toml##<condition>,template.esh,template.ro=truebut the original semantic of those values were conditions, so I'm not sure if that'd be a good approach