fix: 'GetLineByteFromPos' maybe return val overflow #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this overflow maybe a bug from specific server, so perhaps let it be... |
|
um.. i changed my mind, perhaps keep this open whatever it would be going, in case it do required (to fix)... |
Shane-XB-Qian
force-pushed
the
fix_getlinebyteposOverflow
branch
4 times, most recently
from
a94ecd3 to
de15c3b
Compare
|
test was flaky, seems not regarding to this change. |
Shane-XB-Qian
force-pushed
the
fix_getlinebyteposOverflow
branch
3 times, most recently
from
1065141 to
1bef02a
Compare
Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>
Shane-XB-Qian
force-pushed
the
fix_getlinebyteposOverflow
branch
from
1bef02a to
1997f08
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
// supposed it is ok to cover like that..