Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Module.php #498

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Module.php #498

wants to merge 1 commit into from

Conversation

mukhtor
Copy link

@mukhtor mukhtor commented Mar 29, 2022

Q A
Is bugfix? ✔️/❌
New feature? ✔️/❌
Breaks BC? ✔️/❌
Fixed issues

@schmunk42 schmunk42 added the pr:missing usecase It is not clear what is the use case for the pull request. label Mar 29, 2022
@yii-bot
Copy link

yii-bot commented Mar 29, 2022

Thank you for putting effort in the improvement of the Yii framework.
We have reviewed your pull request.

Unfortunately a use case is missing. It is required to get a better understanding of the pull request and helps us to determine the necessity and applicability of the suggested change to the framework.

Could you supply us with a use case please? Please be as detailed as possible and show some code!

Thanks!

This is an automated comment, triggered by adding the label pr:missing usecase.

@schmunk42
Copy link
Contributor

Moreover, there's a syntax error, missing changelog and it is not BC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr:missing usecase It is not clear what is the use case for the pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mukhtor @yii-bot @schmunk42