Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated docker build and publication #54

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Automated docker build and publication #54

merged 1 commit into from
Jan 5, 2025

Conversation

scoopex
Copy link
Collaborator

@scoopex scoopex commented Dec 23, 2024 •
edited
Loading

Add a docker workflow

  • use a shared workflow for the release and development builds
  • update base docker image to zabbix 7.2
  • add docker build and release steps
  • add testing procedure to docker build
  • documentation: add reference to dockerhub

@scoopex scoopex self-assigned this Dec 23, 2024
@scoopex scoopex marked this pull request as draft December 23, 2024 10:43
@scoopex scoopex changed the title Testing automated docker build [DRAFT] Testing automated docker build Dec 23, 2024
@scoopex scoopex marked this pull request as ready for review January 4, 2025 14:35
@scoopex
Add a docker workflow
80ce5ea 
- use a shared workflow for the release and development builds
- update base docker image to zabbix 7.2
- add docker build and release steps
- add testing procedure to docker build
- documentation: add reference to dockerhub
@scoopex scoopex changed the title [DRAFT] Testing automated docker build Automated docker build and publication Jan 4, 2025
@scoopex
Copy link
Collaborator Author

scoopex commented Jan 4, 2025 •
edited
Loading

@jeroenvermeulen ready for review.
As a next step, it might be a good idea also build the os-packages also in a docker container and to put everything in a single script with different options.
What do you think?

jeroenvermeulen
jeroenvermeulen approved these changes Jan 4, 2025
View reviewed changes
Copy link
Collaborator

@jeroenvermeulen jeroenvermeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a quick look but didn't check every line.
LGTM

@scoopex scoopex merged commit 162212c into main Jan 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeroenvermeulen jeroenvermeulen jeroenvermeulen approved these changes

Assignees

@scoopex scoopex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scoopex @jeroenvermeulen