Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow falsy values to be passed to addOption and to the command execu… #23

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Allow falsy values to be passed to addOption and to the command execu… #23

merged 1 commit into from
Oct 28, 2024

Conversation

TristanPouliquen
Copy link
Contributor

@TristanPouliquen TristanPouliquen commented Oct 24, 2024 •
edited
Loading

Fixes #22

Allows to pass falsy values through addOption to the command execution.

@TristanPouliquen
Copy link
Contributor Author

@kbond Would you have time for a quick review here?

kbond
kbond approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @TristanPouliquen, thanks!

@kbond kbond merged commit a90833d into zenstruck:1.x Oct 28, 2024
20 checks passed
@kbond
Copy link
Member

kbond commented Oct 28, 2024

Just released 1.6.1 with this fix.

@TristanPouliquen TristanPouliquen deleted the fix-falsy-values-in-addOption branch October 28, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbond kbond kbond approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

addOption does not allow to pass falsy values to a command
2 participants
@TristanPouliquen @kbond