Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: confirm tokens are stored after configuration setup is complete #129

Merged
merged 7 commits into from
Sep 5, 2024

Conversation

zimeg
Copy link
Owner

@zimeg zimeg commented Sep 3, 2024

edit: also reveals a hidden message from the "devices" endpoint- if one is returned [a squashed bug]. that message might show an "outdated token" message, but that's not such a common case afaik

@zimeg zimeg added code health Care for the characters semver:patch Changes of a patch version labels Sep 3, 2024
@zimeg zimeg added this to the Next release milestone Sep 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 29.34132% with 236 lines in your changes missing coverage. Please review.

Project coverage is 36.68%. Comparing base (eae5463) to head (8a0ebbf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/api/usage.go 0.00% 41 Missing ⚠️
pkg/cognito/cognito.go 0.00% 40 Missing ⚠️
pkg/config/devices.go 42.50% 21 Missing and 2 partials ⚠️
cmd/root.go 0.00% 22 Missing ⚠️
cmd/etime/etime.go 0.00% 21 Missing ⚠️
pkg/api/api.go 0.00% 21 Missing ⚠️
pkg/config/config.go 57.44% 9 Missing and 11 partials ⚠️
pkg/config/credentials.go 71.69% 9 Missing and 6 partials ⚠️
pkg/api/devices.go 0.00% 9 Missing ⚠️
pkg/api/status.go 0.00% 7 Missing ⚠️
... and 5 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #129       +/-   ##
===========================================
+ Coverage   22.20%   36.68%   +14.48%     
===========================================
  Files          16       26       +10     
  Lines         563      597       +34     
===========================================
+ Hits          125      219       +94     
+ Misses        431      350       -81     
- Partials        7       28       +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 3, 2024

@zimeg zimeg added the bug Something isn't working label Sep 5, 2024
@zimeg zimeg merged commit e4a8599 into main Sep 5, 2024
20 checks passed
@zimeg zimeg deleted the test-tokens branch September 5, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working code health Care for the characters semver:patch Changes of a patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants