Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gather configured settings using a generic filepath separator #130

Merged
merged 6 commits into from
Sep 6, 2024

Conversation

zimeg
Copy link
Owner

@zimeg zimeg commented Sep 6, 2024

No description provided.

@zimeg zimeg added bug Something isn't working semver:patch Changes of a patch version labels Sep 6, 2024
@zimeg zimeg added this to the Next release milestone Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 36.89%. Comparing base (e4a8599) to head (ba691d5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/config/config.go 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
+ Coverage   36.68%   36.89%   +0.21%     
==========================================
  Files          26       26              
  Lines         597      599       +2     
==========================================
+ Hits          219      221       +2     
  Misses        350      350              
  Partials       28       28              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 6, 2024

@zimeg zimeg merged commit c07803b into main Sep 6, 2024
20 checks passed
@zimeg zimeg deleted the fix-settings-filepath branch September 6, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working semver:patch Changes of a patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant