fix: rename subheader title variable

zimmerman-team · Oct 30, 2023 · 59de222 · 59de222
1 parent 66939c3
commit 59de222
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 8 deletions.
diff --git a/src/app/modules/common/subheader-toolbar/SubheaderToolbar.tsx b/src/app/modules/common/subheader-toolbar/SubheaderToolbar.tsx
@@ -434,7 +434,7 @@ export function SubheaderToolbar(props: SubheaderToolbarProps) {
             placeholder="Title"
             css={styles.nameInput}
             onChange={onNameChange}
-            onFocus={() => props.setHasReportNameFocused?.(true)}
+            onFocus={() => props.setHasSubHeaderTitleFocused?.(true)}
             onClick={(e) => {
               if (props.name === "Untitled report") {
                 e.currentTarget.value = "";

diff --git a/src/app/modules/common/subheader-toolbar/data.ts b/src/app/modules/common/subheader-toolbar/data.ts
@@ -10,7 +10,7 @@ export interface SubheaderToolbarProps {
   forceEnablePreviewSave?: boolean;
   rawViz?: any;
   reportName: string;
-  setHasReportNameFocused?: (value: boolean) => void;
+  setHasSubHeaderTitleFocused?: (value: boolean) => void;
   headerDetails: IHeaderDetails;
   appliedHeaderDetails: IHeaderDetails;
   framesArray: IFramesArray[];

diff --git a/src/app/modules/report-module/sub-module/components/headerBlock/index.tsx b/src/app/modules/report-module/sub-module/components/headerBlock/index.tsx
@@ -18,7 +18,7 @@ import useDebounce from "react-use/lib/useDebounce";
 
 interface Props {
   previewMode: boolean;
-  hasReportNameFocused?: boolean;
+  hasSubHeaderTitleFocused?: boolean;
   setReportName?: React.Dispatch<React.SetStateAction<string>>;
   reportName?: string;
   headerDetails: {
@@ -73,7 +73,7 @@ export default function HeaderBlock(props: Props) {
     () => {
       // checks when headerDetails.title is empty and report title has not been focused
 
-      if (!props.hasReportNameFocused && isReportTitleModified) {
+      if (!props.hasSubHeaderTitleFocused && isReportTitleModified) {
         props.setReportName?.(props.headerDetails.title);
       }
     },

diff --git a/src/app/modules/report-module/sub-module/rowStructure/rowFrame.tsx b/src/app/modules/report-module/sub-module/rowStructure/rowFrame.tsx
@@ -312,8 +312,6 @@ export default function RowFrame(props: RowFrameProps) {
     });
   };
 
-  console.log(props.framesArray, "framesarray");
-
   React.useEffect(() => {
     setSelectedType(selectedTypeHistory[selectedTypeHistory.length - 1]);
   }, [selectedTypeHistory]);

diff --git a/src/app/modules/report-module/views/create/data.ts b/src/app/modules/report-module/views/create/data.ts
@@ -44,7 +44,7 @@ export interface ReportCreateViewProps {
   setFramesArray: React.Dispatch<React.SetStateAction<IFramesArray[]>>;
   deleteFrame: (id: string) => void;
   framesArray: IFramesArray[];
-  hasReportNameFocused: boolean;
+  hasSubHeaderTitleFocused: boolean;
   handlePersistReportState: () => void;
   headerDetails: {
     title: string;

diff --git a/src/app/modules/report-module/views/create/index.tsx b/src/app/modules/report-module/views/create/index.tsx
@@ -113,7 +113,7 @@ function ReportCreateView(props: ReportCreateViewProps) {
         setHeaderDetails={props.setHeaderDetails}
         setReportName={props.setReportName}
         reportName={props.reportName}
-        hasReportNameFocused={props.hasReportNameFocused}
+        hasSubHeaderTitleFocused={props.hasSubHeaderTitleFocused}
       />
       <Container maxWidth="lg">
         <div