feat:DX-848; show updated chart in report on first load

zimmerman-team · Nov 14, 2023 · 98f35dd · 98f35dd
1 parent 997a47b
commit 98f35dd
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/src/app/modules/common/subheader-toolbar/SubheaderToolbar.tsx b/src/app/modules/common/subheader-toolbar/SubheaderToolbar.tsx
@@ -189,11 +189,11 @@ export function SubheaderToolbar(props: SubheaderToolbarProps) {
   };
 
   React.useEffect(() => {
-    //completes chart creation, returns back to persisted report view
     if (
       (editChartSuccess || createChartSuccess) &&
       createChartFromReport.state
     ) {
+      //returns back to persisted report view
       setCreateChartFromReport({
         ...createChartFromReport,
         state: false,
@@ -206,11 +206,16 @@ export function SubheaderToolbar(props: SubheaderToolbarProps) {
           `/report/${createChartFromReport.page}/${createChartFromReport.view}`
         );
       }
-    } else if (editChartSuccess && !createChartFromReport.state) {
-      history.push(`/chart/${page}`);
     }
   }, [editChartSuccess, createChartSuccess]);
 
+  React.useEffect(() => {
+    if (editChartSuccess && createChartFromReport.view === "") {
+      console.log(createChartFromReport.state, "state");
+      history.push(`/chart/${page}`);
+    }
+  }, [editChartSuccess]);
+
   React.useEffect(() => {
     return () => {
       createChartClear();