Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inspection for "ZIO.fail(throw" #491

Merged
merged 3 commits into from
Nov 23, 2024
Merged

Add inspection for "ZIO.fail(throw" #491

merged 3 commits into from
Nov 23, 2024

Conversation

andrzejressel
Copy link
Contributor

Using ZIO.fail(throw causes exception to be thrown instead of being used as value.

@hmemcpy
Copy link
Collaborator

hmemcpy commented Nov 23, 2024

Ooh, this is a very good inspection! Thank you!
The tests might fail because of a problem with the current Scala plugin version, but this looks great to me. I'll merge it a bit later.
Thank you!

@hmemcpy hmemcpy enabled auto-merge (squash) November 23, 2024 20:07
@hmemcpy hmemcpy disabled auto-merge November 23, 2024 20:08
@hmemcpy hmemcpy merged commit 857c7f9 into zio:idea243.x Nov 23, 2024
1 of 4 checks passed
@andrzejressel andrzejressel deleted the warn_on_zio_fail_throw branch November 24, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrzejressel @hmemcpy