Skip to content

Commit

Permalink
fix: Implemented detailed retry error code logic
Browse files Browse the repository at this point in the history
  • Loading branch information
willguibr committed Apr 9, 2024
1 parent bdd3a2a commit 59e7d29
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 8 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/zia-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
max_attempts: 3
timeout_minutes: 20
command: |
make test:integration:zia
make coverage:zia
env:
ZIA_USERNAME: ${{ secrets.ZIA_USERNAME }}
ZIA_PASSWORD: ${{ secrets.ZIA_PASSWORD }}
Expand Down Expand Up @@ -103,7 +103,7 @@ jobs:
max_attempts: 3
timeout_minutes: 20
command: |
make test:integration:zia
make coverage:zia
env:
ZIA_USERNAME: ${{ secrets.ZIA_USERNAME }}
ZIA_PASSWORD: ${{ secrets.ZIA_PASSWORD }}
Expand All @@ -114,3 +114,5 @@ jobs:
ZPA_CLIENT_SECRET: ${{ secrets.ZPA_CLIENT_SECRET }}
ZPA_CUSTOMER_ID: ${{ secrets.ZPA_CUSTOMER_ID }}
ZPA_CLOUD: ${{ secrets.ZPA_CLOUD }}
needs:
- zia-beta-tenants
8 changes: 4 additions & 4 deletions .github/workflows/zpa_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
max_attempts: 3
timeout_minutes: 20
command: |
make test:integration:zpa
make coverage:zpa
env:
ZPA_CLIENT_ID: ${{ secrets.ZPA_CLIENT_ID }}
ZPA_CLIENT_SECRET: ${{ secrets.ZPA_CLIENT_SECRET }}
Expand Down Expand Up @@ -98,7 +98,7 @@ jobs:
max_attempts: 3
timeout_minutes: 20
command: |
make test:integration:zpa
make coverage:zpa
env:
ZPA_CLIENT_ID: ${{ secrets.ZPA_CLIENT_ID }}
ZPA_CLIENT_SECRET: ${{ secrets.ZPA_CLIENT_SECRET }}
Expand Down Expand Up @@ -145,7 +145,7 @@ jobs:
max_attempts: 3
timeout_minutes: 20
command: |
make test:integration:zpa
make coverage:zpa
env:
ZPA_CLIENT_ID: ${{ secrets.ZPA_CLIENT_ID }}
ZPA_CLIENT_SECRET: ${{ secrets.ZPA_CLIENT_SECRET }}
Expand Down Expand Up @@ -195,7 +195,7 @@ jobs:
max_attempts: 3
timeout_minutes: 20
command: |
make test:integration:zpa
make coverage:zpa
env:
ZPA_CLIENT_ID: ${{ secrets.ZPA_CLIENT_ID }}
ZPA_CLIENT_SECRET: ${{ secrets.ZPA_CLIENT_SECRET }}
Expand Down
4 changes: 2 additions & 2 deletions tests/integration/zia/test_users.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ async def test_users(self, fs):

# Activate Configuration
activation_response = client.activate.activate()
assert activation_response in ["ACTIVE", "PENDING"], "Activation failed or is pending"
assert activation_response in ["ACTIVE", "INPROGRESS", "PENDING"], "Activation failed or is pending"
except Exception as exc:
errors.append(f"User creation or activation failed: {exc}")

Expand Down Expand Up @@ -131,7 +131,7 @@ async def test_users(self, fs):

# Reactivate Configuration after Deletion
activation_response = client.activate.activate()
assert activation_response in ["ACTIVE", "PENDING"], "Activation failed or is pending after deletion"
assert activation_response in ["ACTIVE", "INPROGRESS", "PENDING"], "Activation failed or is pending after deletion"
except Exception as exc:
errors.append(f"Deleting User Account or reactivation failed: {exc}")

Expand Down

0 comments on commit 59e7d29

Please sign in to comment.