-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite Landing Page #17
Conversation
β¦e font and refine the 1080p layout
β¦ailing and redirecting
d27ce3c
to
e9f549d
Compare
7c9839c
to
87c670b
Compare
app/routes/api.issues.ts
Outdated
} | ||
|
||
return json<GitHubLoaderData>({ data: [] }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it will be deprecated in React Routerv7.
This is an official flag comming from Remix. Therefore I don't think they will do any changes or handle it under the hood. See Remix changelog and Remix PR. If they choose to change anything so that json
can be used again, we could change it any time we want to. But to stay future proof and up to date with official Remix releases, I would suggest keeping my change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was the json helper from Remix removed for more boilerplate? See comments
4ce4574
to
c51650d
Compare
π Pull Request
π Linked Issue
Closes #16
π Description
Draft PR for harboring the landing page rewrite code
π οΈ Changes Made
TBD
π§ͺ Testing
πΈ Screenshots (if applicable)
π Additional Notes
β Checklist
π₯ Reviewer Checklist
π Thank you for contributing to Zufall! π