Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Landing Page #17

Merged
merged 23 commits into from
Dec 3, 2024
Merged

Rewrite Landing Page #17

merged 23 commits into from
Dec 3, 2024

Conversation

knht
Copy link
Member

@knht knht commented Nov 7, 2024

πŸš€ Pull Request

πŸ”— Linked Issue

Closes #16

πŸ“ Description

Draft PR for harboring the landing page rewrite code

πŸ› οΈ Changes Made

  • Change 1
  • Change 2
  • Change 3
    TBD

πŸ§ͺ Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Tested manually

πŸ“Έ Screenshots (if applicable)

πŸ” Additional Notes

βœ… Checklist

  • I have read the contributing guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

πŸ‘₯ Reviewer Checklist

  • The code change is focused and makes sense
  • The code adheres to our established coding standards
  • The changes are adequately tested
  • The documentation is updated to reflect the changes (if necessary)

πŸ’– Thank you for contributing to Zufall! πŸ’–

@knht knht linked an issue Nov 7, 2024 that may be closed by this pull request
1 task
@Colin23 Colin23 force-pushed the 16-feature-rewrite-landing-page branch from d27ce3c to e9f549d Compare November 9, 2024 17:17
@Colin23 Colin23 force-pushed the 16-feature-rewrite-landing-page branch from 7c9839c to 87c670b Compare November 9, 2024 18:40
}

return json<GitHubLoaderData>({ data: [] });
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this changed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it will be deprecated in React Routerv7.
image

This is an official flag comming from Remix. Therefore I don't think they will do any changes or handle it under the hood. See Remix changelog and Remix PR. If they choose to change anything so that json can be used again, we could change it any time we want to. But to stay future proof and up to date with official Remix releases, I would suggest keeping my change.

Copy link
Member Author

@knht knht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was the json helper from Remix removed for more boilerplate? See comments

@Colin23 Colin23 force-pushed the 16-feature-rewrite-landing-page branch from 4ce4574 to c51650d Compare December 1, 2024 20:55
@knht knht marked this pull request as ready for review December 3, 2024 17:54
@knht knht merged commit f8e26b7 into main Dec 3, 2024
1 check passed
@Colin23 Colin23 deleted the 16-feature-rewrite-landing-page branch December 13, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Rewrite Landing Page
2 participants