-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: prevent typing over-long topic names #1230
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: ARYPROGRAMMER <arya.2023ug1104@iiitranchi.ac.in>
Thanks. Before we can review this PR, it will need (a) tests, and (b) to remove extraneous changes so that the commit is readable. See our README: |
surely greg, the file was auto formatted thus it happened so. For the tests, I'll just look into it and fix it |
Signed-off-by: ARYPROGRAMMER <arya.2023ug1104@iiitranchi.ac.in>
Signed-off-by: ARYPROGRAMMER <arya.2023ug1104@iiitranchi.ac.in>
@gnprice lgtm now , go ahead with the review. Let me know further |
hey greg any updates? |
This still has extraneous changes which you'll need to remove before we can review it. See the link I posted above, and see in particular the Zulip guide to clear and coherent commits which is linked from there. There's also no need to re-ping after a day. Reviewers have weekends, and holidays, and also other work responsibilities. If it's been a week or two since you requested review and there's no reply, then it can be appropriate to bump the thread. |
Signed-off-by: Arya Pratap Singh <notaryasingh@gmail.com>
Signed-off-by: Arya Pratap Singh <notaryasingh@gmail.com>
let me know whether I should pull changes from #1239 and add them to this PR |
This PR adds the functionality mentioned in the Issue #1218
Demo Video on a real android device:
demo.mp4