Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prevent typing over-long topic names #1230

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ARYPROGRAMMER
Copy link

This PR adds the functionality mentioned in the Issue #1218

  • It implements a value notifier, adds a listener and creates a function to enforce limit.
  • Displays the limit alongside current characters
  • Does not change any core functionality and does not break anything else

Demo Video on a real android device:

demo.mp4

Signed-off-by: ARYPROGRAMMER <arya.2023ug1104@iiitranchi.ac.in>
@gnprice
Copy link
Member

gnprice commented Dec 28, 2024

Thanks. Before we can review this PR, it will need (a) tests, and (b) to remove extraneous changes so that the commit is readable. See our README:
https://github.com/zulip/zulip-flutter?tab=readme-ov-file#submitting-a-pull-request

@ARYPROGRAMMER
Copy link
Author

Thanks. Before we can review this PR, it will need (a) tests, and (b) to remove extraneous changes so that the commit is readable. See our README: https://github.com/zulip/zulip-flutter?tab=readme-ov-file#submitting-a-pull-request

surely greg, the file was auto formatted thus it happened so. For the tests, I'll just look into it and fix it

Signed-off-by: ARYPROGRAMMER <arya.2023ug1104@iiitranchi.ac.in>
Signed-off-by: ARYPROGRAMMER <arya.2023ug1104@iiitranchi.ac.in>
Signed-off-by: ARYPROGRAMMER <arya.2023ug1104@iiitranchi.ac.in>
@ARYPROGRAMMER
Copy link
Author

@gnprice lgtm now , go ahead with the review. Let me know further

@ARYPROGRAMMER
Copy link
Author

Thanks. Before we can review this PR, it will need (a) tests, and (b) to remove extraneous changes so that the commit is readable. See our README: https://github.com/zulip/zulip-flutter?tab=readme-ov-file#submitting-a-pull-request

surely greg, the file was auto formatted thus it happened so. For the tests, I'll just look into it and fix it

hey greg any updates?

@gnprice
Copy link
Member

gnprice commented Dec 30, 2024

This still has extraneous changes which you'll need to remove before we can review it. See the link I posted above, and see in particular the Zulip guide to clear and coherent commits which is linked from there.

There's also no need to re-ping after a day. Reviewers have weekends, and holidays, and also other work responsibilities. If it's been a week or two since you requested review and there's no reply, then it can be appropriate to bump the thread.

@chrisbobbe
Copy link
Collaborator

chrisbobbe commented Dec 30, 2024

Since #1218 will make our max-length check more prominent (acting even before you tap "send"), ideally we would fix a correctness issue before implementing this. I've just filed that correctness issue as #1238.

Signed-off-by: Arya Pratap Singh <notaryasingh@gmail.com>
Signed-off-by: Arya Pratap Singh <notaryasingh@gmail.com>
@ARYPROGRAMMER
Copy link
Author

let me know whether I should pull changes from #1239 and add them to this PR

@chrisbobbe
Copy link
Collaborator

chrisbobbe commented Jan 2, 2025

I recommend either rebasing your PR on top of my current revision for #1239 or pausing work on it until #1239 settles.

@ARYPROGRAMMER
Copy link
Author

I recommend either rebasing your PR on top of my current revision for #1239 or pausing work on it until #1239 settles.

I think we can wait till #1239 finishes. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants