Ensure all task exceptions are handled, to prevent crashes. #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Out of curiosity @Erfa, what one scenario led to the crash when calling |
I was running it on an emulator which I had apparently loaded with an image that didn't have Play Store support. Reproducible every time for me. |
Abedalkareem
approved these changes
Jan 8, 2024
|
@Abedalkareem I will have the permission request sorted within a couple of days. |
|
This also closes #149. |
theLee3
requested changes
Jan 25, 2024
|
Something like that? |
|
Perfect. Thanks @Erfa. |
theLee3
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task.result.get()crashes for me when callingloadAchievementin one scenario. I don't think this is intentional? Seems like this should be handled by the failure listener which was already present. After this change it is.I also changed a similar case with leaderboards and saves. After this no completeListeners should assume that data exists.
Disclaimer: I don't really know Kotlin and haven't worked with native Android in years, but it seems pretty straightforward.