Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6186: Add option to provide tooltips to message boxes #14500

Merged
merged 16 commits into from
Oct 20, 2023

Conversation

aparajit-pratap
Copy link
Contributor

@aparajit-pratap aparajit-pratap commented Oct 19, 2023

Purpose

Added a way to add tooltips to DynamoMessageBox.
Added one for ElementBinding Warning message box that appears on SaveAs in certain scenarios.

image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Mandatory section

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

@Jingyi-Wen

@aparajit-pratap aparajit-pratap changed the title Add option to provide tooltips to message boxes DYN-6186: Add option to provide tooltips to message boxes Oct 19, 2023
Copy link
Contributor

@pinzart90 pinzart90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mjkkirschner mjkkirschner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just small comments but nothing that blocks this from being merged.

@aparajit-pratap aparajit-pratap merged commit 1cccba1 into DynamoDS:master Oct 20, 2023
17 checks passed
@aparajit-pratap aparajit-pratap deleted the addTooltip branch October 20, 2023 13:43
@QilongTang QilongTang added this to the 3.0 milestone Oct 20, 2023
@QilongTang
Copy link
Contributor

Oops, I'm late to the party. I was going to suggest a visibility converter binded to the tooltip so if the tooltip is empty we do not show the question mark..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants