-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick PRs 14394, 14424, 14500, 14740 #15032
Cherry-pick PRs 14394, 14424, 14500, 14740 #15032
Conversation
…nitialized to null (DynamoDS#14703) * remove coreclr-ncalc references * add failing test for dropdown node * cleanup * update tests * attempt initial fix * cleanup * update test * review comments * add code comments
* remove coreclr-ncalc references * fix for element binding messagebox on saveas
Is the element binding one a must have? Because that cherry pick introduce new resource strings while the localization process is done for 2.19.5 |
Ah, sorry I think I am getting confused between the |
IMO - having the dialog which a user could translate themselves with more info is better than not having it - alternatively we could make it a known issue... which we also don't translate ;) |
I agree with having the messaging even if it's missing localization as it will be good to have something than nothing at all. |
|
Purpose
Cherry-pick PRs #14394, #14424, #14500, #14740
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of