Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GSK-1914] Made kwargs default value persistent in the Hub #1508

Merged
merged 3 commits into from
Oct 31, 2023
Merged

[GSK-1914] Made kwargs default value persistent in the Hub #1508

merged 3 commits into from
Oct 31, 2023

Conversation

kevinmessiaen
Copy link
Member

Description

Made kwargs default value persistent in the Hub

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

@linear
Copy link

linear bot commented Oct 26, 2023

GSK-1914 CTA Push: test slicing F1 difference is putting a kwarg as test input

  • The name of the test should be: "Test F1 on slice "XXX" contains "XXX"
  • the test input should not be a "kwarg"

See the video below

Screen Recording 2023-10-19 at 14.42.20.mov

@Hartorn Hartorn force-pushed the feature/gsk-1914-cta-push-test-slicing-f1-difference-is-putting-a-kwarg-as branch from 0ce3c85 to 496a2b4 Compare October 31, 2023 15:33
Hartorn
Hartorn requested changes Oct 31, 2023
View reviewed changes
Copy link
Member

@Hartorn Hartorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buildTestArgumentWS is raising a null pointer exception in the hub, when using this.
Is there a hub PR i did not see ?

@Hartorn Hartorn force-pushed the feature/gsk-1914-cta-push-test-slicing-f1-difference-is-putting-a-kwarg-as branch from 551f7b6 to 3083a2c Compare October 31, 2023 18:45
@Hartorn Hartorn changed the base branch from main to fix-debug-master October 31, 2023 18:45
@Hartorn Hartorn force-pushed the feature/gsk-1914-cta-push-test-slicing-f1-difference-is-putting-a-kwarg-as branch from 3083a2c to 9efbce1 Compare October 31, 2023 19:10
@Hartorn Hartorn changed the title Made kwargs default value persistent in the Hub [GSK-1914] Made kwargs default value persistent in the Hub Oct 31, 2023
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@andreybavt andreybavt merged commit d738c99 into fix-debug-master Oct 31, 2023
16 checks passed
@andreybavt andreybavt deleted the feature/gsk-1914-cta-push-test-slicing-f1-difference-is-putting-a-kwarg-as branch October 31, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hartorn Hartorn Hartorn approved these changes

@Inokinoki Inokinoki Awaiting requested review from Inokinoki

@Googleton Googleton Awaiting requested review from Googleton

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevinmessiaen @Hartorn @andreybavt