-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Dynamic web stories from backend #892
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
…ysis-tool into feat/dynamic-web-stories
Add loading State.
Add debounce capability.
…s/ps-analysis-tool into feat/dynamic-web-stories
Reduce postmessage from parent.
…ysis-tool into feat/dynamic-web-stories
Initialize listener at the bottom of the script.
It works in vertical mode however the placement of arrow down doesn't look right. |
Add no stories found.
No Stories found text is not styled. The arrow is still on the extreme right in the vertical mode. Click on the arrow down is loading more stories, but it would be good if we also scroll to the bottom to show new stories. After new stories are loaded and there are no more stories left, we should hide the arrow down. After the we click on arrow up and the user scrolls to the top, arrow up should update as the user can no longer scroll up.
Add loader to display loader for load more.
Fix bug
mohdsayed
reviewed
Dec 27, 2024
mohdsayed
reviewed
Dec 27, 2024
mohdsayed
reviewed
Dec 27, 2024
packages/extension/src/view/devtools/stateProviders/webStories/webStoriesProvider.tsx
Outdated
Show resolved
Hide resolved
mohdsayed
reviewed
Dec 27, 2024
packages/extension/src/view/devtools/stateProviders/webStories/webStoriesProvider.tsx
Outdated
Show resolved
Hide resolved
mohdsayed
reviewed
Dec 27, 2024
packages/extension/src/view/devtools/stateProviders/webStories/webStoriesProvider.tsx
Show resolved
Hide resolved
mohdsayed
requested changes
Dec 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs few improvements.
mohdsayed
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to build dynamic stories from the backend response.
Relevant Technical Choices
Category
,Author
andTags
from API calls to the backend.Testing Instructions
npm i && npm run build:ext
.Additional Information:
The following things are to be done:
Screenshot/Screencast
Checklist
- [ ] This code is covered by unit tests to verify that it works as intended.Fixes #897