fix(plugins): grpc-web, grpc-gateway: TE trailers #14042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/pdk
cherry-pick kong-ee
gszr
force-pushed
the
fix/grpc-web-and-gateway-trailers
branch
from
167aba5 to
9400e9d
Compare
gszr
force-pushed
the
fix/grpc-web-and-gateway-trailers
branch
from
9400e9d to
9aece78
Compare
|
Fixes #14043. |
gszr
force-pushed
the
fix/grpc-web-and-gateway-trailers
branch
5 times, most recently
from
63040b7 to
4cfc45a
Compare
brentos
approved these changes
Dec 20, 2024
Ensure `TE` headers is properly sent to gRPC upstream server in request generated from Kong. Previously, the call to `kong.service.request.set_headers` was not taking effect as the `TE` headers cannot be set through normal OpenResty APIs; this PR ensures it's set in a similar way as the `:authority` pseudo-header.
gszr
force-pushed
the
fix/grpc-web-and-gateway-trailers
branch
from
4cfc45a to
ee9396b
Compare
kevwilliams
approved these changes
Dec 23, 2024
gruceo
approved these changes
Dec 23, 2024
gszr
added
the
pr/ready (but hold merge)
|
Please hold on merging. The issue this fixes appears to be a regression; discussion ongoing offline (FTI-6410). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure
TEheaders is properly sent to gRPC upstream server in request generated from Kong by thegrpc-webandgrpc-gatewayplugins. Previously, the call tokong.service.request.set_headerswas not taking effect as theTEheaders cannot be set through normal OpenResty APIs; this PR ensures it's set in a similar way as the:authoritypseudo-header. This fix ensures our implementation complies with the gRPC spec, which mandates aTE: trailersheader in gRPPC over http/2 requests.