Update to handle the new JSON format introduced in Xcode 15.3 #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabc
requested review from
polac24,
ecamacho,
aleksandergrzyb and
CognitiveDisson
as code owners
|
Hey @rabc! Thanks for the PR. If you can fix the SwiftLint issues, we can go ahead and merge it 👍 |
|
@rabc thank you for this -- i tested on my project and all is working :) |
|
Thank you so much for the fix! |
|
@rabc any updates on this PR? I'd love to get this fix in! |
|
@AvdLee I think that only the review is needed. @polac24 @ecamacho @aleksandergrzyb @CognitiveDisson anyone can check and review it please? |
|
@rabc, thank. Can you please also Sign off your commits to meet DCO. The PR looks nice. |
Signed-off-by: Ricardo Carvalho <ricardo.abc@gmail.com>
Signed-off-by: Ricardo Carvalho <ricardo.abc@gmail.com>
|
@polac24 Done! Let me know if you need help to maintain this repo 😄 |
polac24
approved these changes
Apr 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xcode 15.3 added a new JSON format
BuildOperationTaskMetrics. This PR handles the new token*to fix #203 . If more people can test it to check that it is being handled correctly in more use cases.I only added it to the parser, but not to the report and the json outputs.