Added tests for ProjectileImpactEvent #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will be merged with the API PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for ProjectileImpactEvent. I went through and verified that Forge behavior matched Patchwork behavior, but I would appreciate more eyes to check it out.
Just as a disclaimer, this is a little bit of a menial PR to add tests, so if it would be better to keep tests like this separate, just let me know.
The tests include:
Generic Projectile Events
Arrow Projectile Events
Fireball Projectile Events
Throwable Projectile Events
Custom Projectile Events
Corresponding patchwork-api PR: PatchworkMC/patchwork-api#168