Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coding guidelines: remove bool advice that conflicts with clang-tidy #15016

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

Habbie
Copy link
Member

@Habbie Habbie commented Jan 6, 2025

Short description

noted by @BozhanL in #14993

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

CODING_GUIDELINES.md Outdated Show resolved Hide resolved
Co-authored-by: Miod Vallat <miod.vallat@open-xchange.com>
@coveralls
Copy link

coveralls commented Jan 6, 2025

Pull Request Test Coverage Report for Build 12633751652

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 93 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-0.04%) to 64.819%

Files with Coverage Reduction New Missed Lines %
pdns/backends/gsql/gsqlbackend.hh 1 97.71%
pdns/recursordist/lwres.cc 2 69.66%
ext/json11/json11.cpp 2 62.72%
pdns/sstuff.hh 2 56.83%
pdns/opensslsigners.cc 2 61.13%
pdns/stubresolver.cc 3 77.58%
pdns/misc.cc 3 64.45%
pdns/dnsdistdist/dnsdist-carbon.cc 6 61.6%
pdns/recursordist/test-syncres_cc1.cc 7 89.68%
pdns/recursordist/syncres.cc 10 80.09%
Totals Coverage Status
Change from base Build 12632986338: -0.04%
Covered Lines: 126124
Relevant Lines: 163796

💛 - Coveralls

@Habbie Habbie merged commit 679f72f into PowerDNS:master Jan 7, 2025
77 checks passed
@Habbie Habbie deleted the no-bool-explicit-cmp branch January 7, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants