Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coding guidelines: remove bool advice that conflicts with clang-tidy #15016

Merged
merged 2 commits into from
Jan 7, 2025
Merged

coding guidelines: remove bool advice that conflicts with clang-tidy #15016

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90e3098
coding guidelines: remove bool advice that conflicts with clang-tidy
Habbie Jan 6, 2025
60eba86
better text
Habbie Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions CODING_GUIDELINES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,8 +611,7 @@ Without `auto`, code might still compile but trigger a copy or worse.
## Explicit Comparisons

* Compare numerical values with `== 0` or `!= 0` explicitly ;
* Compare to `false` explicitly, which is easier to read ;
* Compare to `nullptr` for the same reason.
* Compare to `nullptr`, which is easier to read.

## Initialization

Expand Down
Loading