Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fixes #197

Open
wants to merge 5 commits into
base: development
Choose a base branch
from

Conversation

ZeppelinGames
Copy link
Contributor

  • Fixed BuildWindow crash due to substring name missing char
  • Added GetDefaultAssets function to AssetDatabaseUtils
  • Added default assets to be packed in Desktop compilation. Fixes building projects that use default assets and had asset packing set to 'used assets'
  • Uniformity on project window loading overlay (doubleclicking project now does same action as clicking 'open' button)

@PaperPrototype
Copy link
Contributor

yay

@@ -469,8 +497,21 @@ private void DrawProjectContextMenu(Project project)
{
using (popupHolder.Width(180).Padding(5).Layout(LayoutType.Column).Spacing(5).FitContentHeight().Enter())
{
// Getting Interactable (IsHovered) removes interaction from styled buttons?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit odd, IsHovered and Interactables are just rectangles, this should work just fine with IsHovered?
Could you elaborate on what happened here? Did interaction just completely fail?

Other then this (which isn't really a problem preventing merging) everything looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants