This repository has been archived by the owner on Nov 1, 2020. It is now read-only.
Feature cleanup memory leaks #390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VZout
suggested changes
Jun 20, 2019
There was a problem hiding this comment.
looks good but please revert the changes to the frame graph. That is not a good solution.we should use a base class but right now the easiest solution would be to change the stored data type from void* to shared/unique_pointer which would call the destructor I believe if you initialize it from the correct type. still return Object* instead of shared to keep the changes to a minimum.
src/frame_graph/frame_graph.hpp
Outdated
| { | ||
| delete data; | ||
| free(data); |
There was a problem hiding this comment.
I'll change it to std::shared_ptrlike suggested
…ean up file watcher. Clean up registries. Clean up temporary shapes.
|
not mergable |
… and RTAO shader registries
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#387