Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP-663 (Partial): Reduce logging volume #257

Merged
merged 2 commits into from
Nov 10, 2023
Merged

PP-663 (Partial): Reduce logging volume #257

merged 2 commits into from
Nov 10, 2023

Conversation

io7m
Copy link
Contributor

@io7m io7m commented Nov 10, 2023

What's this do?
This makes a couple of changes to assist with (but not solve PP-663):

  • We no longer log account list icons, because some of them are still giant base64 encoded PNGs that end up in logs.
  • We accept the fact that book database entries can disappear when syncing bookmarks

Why are we doing this? (w/ JIRA link if applicable)
Affects: https://ebce-lyrasis.atlassian.net/browse/PP-663

How should this be tested? / Do these changes have associated tests?
Nothing, really. There's just less noise in the logs now.

Dependencies for merging? Releasing to production?
None.

Have you updated the changelog?
N/A

Has the application documentation been updated for these changes?
N/A

Did someone actually run this code to verify it works?
@io7m Enjoyed the peace and quiet.

@io7m io7m merged commit 2a3380a into main Nov 10, 2023
1 check failed
@io7m io7m deleted the feature/pp-663 branch November 10, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants