fix: change seed for variantutils to ensure fair distribution #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivarconr
approved these changes
Oct 26, 2023
ivarconr
approved these changes
Oct 27, 2023
ivarconr
reviewed
Oct 27, 2023
| } | ||
|
|
||
| public static int getNormalizedNumber(String identifier, String groupId, int normalizer) { | ||
| public static int getNormalizedNumber( | ||
| String identifier, String groupId, int normalizer, long seed) { |
There was a problem hiding this comment.
This was done on purpose so every call site has to consider its seed.
fix: Dependent feature is not enabled if parent is disabled, even if parent's variant is the disabled one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Uses a new seed for ensuring a fair distrbution for variants.
Background
After a customer reported that variant distribution seemed skewed we performed some testing and found that since we use the same hash string for both gradual rollout and variant allocation we'd reduced the set of groups we could get to whatever percentage our gradual rollout was set.
Example
Take a gradualRollout of 10%, this will select normalized hashes between 1 and 10, when we then again hash the same string that gave us between 1 and 10, but with modulo 1000 for variants, this will only give us 100 possible groups, instead of the expected 1000.
Fix
Force the normalization to accept a seed, and make sure to use a new seed when normalizing the variant distribution hash.
Worth noting
This will require release 9.0.0, since we're changing the signature of public methods.