-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move to Pydantic 2.0 and use the 1.10 patch branch #163
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 93 93
Lines 1398 1398
Branches 25 25
=========================================
Hits 1398 1398 ☔ View full report in Codecov by Sentry. |
Dependent tests are expected to fail as they have version conflicts due to their dependency constraints. See testing notes for more details. |
Out of interest, is there a timeline for this PR being worked on? I'm working on a project that uses Braket (including this library and https://github.com/amazon-braket/amazon-braket-default-simulator-python) and because of these dependencies we're still limited to Pydantic v1. Would be good to be able to upgrade! |
Hi @isobelhooper and apologies for the delay. The team is currently exploring options to make these upgrades, we will post more information in this thread when we have an update. |
Relaxing constraints in the default simulator: amazon-braket/amazon-braket-default-simulator-python#224 |
maybe not super elegant, but fwiw to avoid conflicts with downstream dependencies you could also use something like try:
from pydantic.v1 import ...
except ImportError:
from pydantic import ... everywhere (at least temporarily) and just pin |
Hi @richrines1, thank you for the suggestion. The team is going to use a slightly different release method with pinned versions to unblock this. |
Issue #, if available:
Description of changes:
Ran:
Testing done:
Passed
tox
execution and tested the branch with the SDK and Default-sim repos with similar patches. Both successfully passedtox
executions.Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.