update mcm-sim version #840
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajberdy
reviewed
Dec 20, 2023
setup.py
Outdated
| @@ -32,7 +32,7 @@ | |||
| # to get the version of the simulator that supports the mcm=True argument for Monte Carlo | |||
| # simulation of mid-circuit measurement, which AutoQASM requires. | |||
| # NOTE: This change should remain in the feature/autoqasm branch; do not merge to main. | |||
| "amazon-braket-default-simulator @ git+https://github.com/aws/amazon-braket-default-simulator-python.git@46aea776976ad7f958d847c06f29f3a7976f5cf5#egg=amazon-braket-default-simulator", # noqa E501 | |||
| "amazon-braket-default-simulator @ git+https://github.com/aws/amazon-braket-default-simulator-python.git@61ce2136e42bdac71fc3df204d4f09a83bb3aed4#egg=amazon-braket-default-simulator", # noqa E501 | |||
There was a problem hiding this comment.
why don't we just point to the branch?
There was a problem hiding this comment.
I recall the reason is that mcm-sim and AutoQASM are both developing and sometime UX breaks with updates. So we pin to commit hash instead of the branch itself.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/autoqasm #840 +/- ##
===================================================
Coverage 100.00% 100.00%
===================================================
Files 166 166
Lines 9959 10081 +122
Branches 2113 2148 +35
===================================================
+ Hits 9959 10081 +122 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.