Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mcm-sim version #840

Closed
wants to merge 4 commits into from
Closed

update mcm-sim version #840

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c07d6d6
update mcm-sim version
yitchen-tim Dec 18, 2023
8196995
update CI check to skip building for python 3.9
yitchen-tim Dec 21, 2023
b717a72
Update python-package.yml
yitchen-tim Dec 21, 2023
18ad885
Update setup.py
yitchen-tim Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
# to get the version of the simulator that supports the mcm=True argument for Monte Carlo
# simulation of mid-circuit measurement, which AutoQASM requires.
# NOTE: This change should remain in the feature/autoqasm branch; do not merge to main.
"amazon-braket-default-simulator @ git+https://github.com/aws/amazon-braket-default-simulator-python.git@46aea776976ad7f958d847c06f29f3a7976f5cf5#egg=amazon-braket-default-simulator", # noqa E501
"amazon-braket-default-simulator @ git+https://github.com/aws/amazon-braket-default-simulator-python.git@61ce2136e42bdac71fc3df204d4f09a83bb3aed4#egg=amazon-braket-default-simulator", # noqa E501
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why don't we just point to the branch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recall the reason is that mcm-sim and AutoQASM are both developing and sometime UX breaks with updates. So we pin to commit hash instead of the branch itself.

"oqpy~=0.3.3",
"setuptools",
"backoff",
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,4 +142,4 @@ commands =
deps =
# If you need to test on a certain branch, add @<branch-name> after .git
git+https://github.com/amazon-braket/amazon-braket-schemas-python.git
git+https://github.com/amazon-braket/amazon-braket-default-simulator-python.git@46aea776976ad7f958d847c06f29f3a7976f5cf5 # mcm-sim branch
git+https://github.com/amazon-braket/amazon-braket-default-simulator-python.git@61ce2136e42bdac71fc3df204d4f09a83bb3aed4 # mcm-sim branch
Loading