Fixed CardBrowser Heading Language Change

[soCallmeAdityaKumar]

Purpose / Description

On Changing the language, heading doesn't changes immediately

Fixes

• Fixes [BUG]: Browser Column Headers Language Doesn't Change #17367

Approach

WhatsApp.mp4

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[david-allison]

• Is it feasible to add a unit test for this one? The ViewModel should be well tested.
• Is it feasible to move this inside the ViewModel, so the UI is reacting to a change in ViewModel
• Should this be in onConfigurationChanged or onResume?
  • Is it worthwhile to add an AnkiDroid Language Changed event?
  • ^ maybe not, given we shouldn't be handling configuration changes manually most of the time

[david-allison]

Rename: two methods one after the other with the same name

[soCallmeAdityaKumar]

Done

[david-allison]

as below, revert + react to the ViewModel change

[soCallmeAdityaKumar]

There is one problem like i am not able to identify , i am open for suggestion:)
When we change the language from system language to some other and again change it to system language it does not change immediately(like the actual issue)

[david-allison]

I don't believe this is ready to review as you've identified an issue. Please un-draft when ready

[soCallmeAdityaKumar]

@david-allison i have noticed that certain text in cardBrowser are not translated properly if language is changed from other language to SystemLanguage.Other language changes are handled properly

WhatsApp.Video.2024-12-07.at.2.19.03.PM.mp4

[david-allison]

That's a known issue. Focus on the column headers, as those are defined in the ViewModel

[soCallmeAdityaKumar]

@david-allison i need to add tests for viewmodel for this case or is there something more I have to do?

[david-allison]

That's it

[soCallmeAdityaKumar]

@david-allison i have tried but i am not able add tests for this, because i am not able to find a way to change the language in test so that the new column2candidates are fetched on automatically.

[david-allison]

Look into how the preferences screen does it

[david-allison]

@soCallmeAdityaKumar Still waiting for feedback though?

[soCallmeAdityaKumar]

@soCallmeAdityaKumar Still waiting for feedback though?

yeah still i am working on this, figuring out

[soCallmeAdityaKumar]

@david-allison opened a new pr for this ->#17687
got merge conflicts and then messed with the files, so opened a new one, hope it fixes the and close this issue , added the test in that

[mikehardy]

got merge conflicts and then messed with the files, so opened a new one

Inability to drive git well as a user isn't a great reason to break the conversation / review context on a PR by hopping over to another one. It seems that spending some quality time getting better at driving git would pay dividends

[soCallmeAdityaKumar]

got merge conflicts and then messed with the files, so opened a new one

Inability to drive git well as a user isn't a great reason to break the conversation / review context on a PR by hopping over to another one. It seems that spending some quality time getting better at driving git would pay dividends

sorry, @mikehardy , i was not diverting the conversation, just got messed with local files and got lost the track so opened a new fresh branch , i am still learning git

[soCallmeAdityaKumar]

@david-allison i have added the test should i open this

[david-allison]

Yes, but please fix the git history. It makes it difficult to review

[david-allison]

This test passes on main

Index: AnkiDroid/src/test/java/com/ichi2/anki/browser/CardBrowserViewModelTest.kt
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/AnkiDroid/src/test/java/com/ichi2/anki/browser/CardBrowserViewModelTest.kt b/AnkiDroid/src/test/java/com/ichi2/anki/browser/CardBrowserViewModelTest.kt
--- a/AnkiDroid/src/test/java/com/ichi2/anki/browser/CardBrowserViewModelTest.kt	(revision d35746b7aeee5db0e34029099c261391fc3d65a8)
+++ b/AnkiDroid/src/test/java/com/ichi2/anki/browser/CardBrowserViewModelTest.kt	(date 1735918889736)
@@ -65,6 +65,7 @@
 import org.hamcrest.Matchers.nullValue
 import org.junit.Test
 import org.junit.runner.RunWith
+import org.robolectric.annotation.Config
 import timber.log.Timber
 import java.io.File
 import kotlin.io.path.createTempDirectory
@@ -88,6 +89,19 @@
             assertThat("filters should be empty after removing", savedSearches().size, equalTo(0))
         }
 
+    @Test
+    @Config(qualifiers = "da")
+    fun `change language to dansk and check columnHeaders`() =
+        runViewModelTest {
+            setColumn1(QUESTION)
+            val column1Header = column1Candidates[0].notesModeLabel
+            assertThat("column1 headers is not question", column1Header, not(QUESTION))
+
+            setColumn2(ANSWER)
+            val column2Header = column2Candidates[0].notesModeLabel
+            assertThat("column2 headers is not question", column2Header, not(ANSWER))
+        }
+
     @Test
     fun `saving search with same name fails`() =
         runViewModelTest {

[soCallmeAdityaKumar]

Yes, but please fix the git history. It makes it difficult to review

Ok will do this .