fix: estimator.deploy not respecting instance type #4724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JGuinegagne
approved these changes
Jun 10, 2024
patrickmcarlos
approved these changes
Jun 10, 2024
akrishna1995
approved these changes
Jun 10, 2024
jiapinw
pushed a commit
to jiapinw/sagemaker-python-sdk
that referenced
this pull request
Jun 25, 2024
* fix: estimator.deploy not respecting instance type * chore: add inline comment about using user supplied instance type
makungaj1
pushed a commit
to makungaj1/sagemaker-python-sdk
that referenced
this pull request
Jul 8, 2024
* prepare release v2.222.0 * update development version to v2.222.1.dev0 * fix: estimator.deploy not respecting instance type (aws#4724) * fix: estimator.deploy not respecting instance type * chore: add inline comment about using user supplied instance type * First changes (aws#4723) Co-authored-by: Bryannah Hernandez <brymh@amazon.com> * prepare release v2.222.1 * update development version to v2.222.2.dev0 * change: update image_uri_configs 06-12-2024 07:17:03 PST * fix: Fix ci unit-tests (aws#4728) * Implement custom telemetry logging in SDK (aws#4721) * Fix Sniping bug fix (aws#4730) * Python SDK bucket sniping fix bug * Python SDK bucket sniping fix bug * Minor fixes to default bucket function and fixing unit tests * fix - Fixes from Pylint failures * fix - Fixes from Flake8 failures * fix - More Flake8 fixes * fix - Remove Whitespace from blankline * fix - Fix black recommendations * fix - Adjust tabbing --------- Co-authored-by: Jiao Liu <liujiaor@amazon.com> Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com> * feature: add 'ModelCard' property to Register step (aws#4726) * feature: add 'ModelCard' property to RegisterModel step * Updated ModelCard content type * fix: ModelCard Object integ Test fix --------- Co-authored-by: Gokul A <166456257+nargokul@users.noreply.github.com> * prepare release v2.223.0 * update development version to v2.223.1.dev0 * Fix Dependabot Issues - MLFlow Version (aws#4731) * fix - Address Dependapot issues * fix -Update MLFLOW Version * Fix: AttributeError: 'NoneType' object has no attribute 'len' error in session.py (aws#4735) * fix - Address Dependapot issues * fix -Update MLFLOW Version * fix - Update fetching Length for NoneType Error * change: Enable telemetry logging for Remote function (aws#4729) * change: Enhance telemetry logging module and feature coverage * Fix default session issue * fix unit-tests * chore: use ml.g5.2xlarge for integ test (aws#4741) * feat: JumpStartModel attach (aws#4680) * feat: JumpStartModel attach * fix: unit tests * chore: change order of kwargs to pass unit tests * chore: update docstrings, add tests * fix: docstring * fix: integ tests * chore: address PR comments --------- Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com> * Upgrading to PT 2.3 for release (aws#4732) * upgrading to PT 2.3 for release * reverting mistake in modifying dataparallel --------- Co-authored-by: Andrew Tian <tinandr@amazon.com> Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com> * feat(sagemaker-mlflow): New features for SageMaker MLflow (aws#4744) * feat: add support for mlflow inputs (aws#1441) * feat: add support for mlflow inputs * fix: typo * fix: doc * fix: S3 regex * fix: refactor * fix: refactor typo * fix: pylint * fix: pylint * fix: black and pylint --------- Co-authored-by: Jacky Lee <drjacky@amazon.com> * fix: lineage tracking bug (aws#1447) * fix: lineage bug * fix: lineage * fix: add validation for tracking ARN input with MLflow input type * fix: bug * fix: unit tests * fix: mock * fix: args --------- Co-authored-by: Jacky Lee <drjacky@amazon.com> * [Fix] regex for RunId to handle empty artifact path and change mlflow plugin name (aws#1455) * [Fix] run id regex pattern such that empty artifact path is handled * Change mlflow plugin name as per legal team requirement * Update describe_mlflow_tracking_server call to align with api changes (aws#1466) * feat: (sagemaker-mlflow) Adding Presigned Url function to SDK (aws#1462) (aws#1477) * mlflow presigned url changes * addressing design feedback * test changes * change: mlflow plugin name (aws#1489) Co-authored-by: Jacky Lee <drjacky@amazon.com> --------- Co-authored-by: Jacky Lee <dr.jackylee@gmail.com> Co-authored-by: Jacky Lee <drjacky@amazon.com> Co-authored-by: jiapinw <95885824+jiapinw@users.noreply.github.com> Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com> * prepare release v2.224.0 * update development version to v2.224.1.dev0 * fix: Model server override logic (aws#4733) * fix: Model server override logic * Fix formatting --------- Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com> * chore(deps): bump apache-airflow from 2.9.1 to 2.9.2 in /requirements/extras (aws#4740) Bumps [apache-airflow](https://github.com/apache/airflow) from 2.9.1 to 2.9.2. - [Release notes](https://github.com/apache/airflow/releases) - [Changelog](https://github.com/apache/airflow/blob/main/RELEASE_NOTES.rst) - [Commits](apache/airflow@2.9.1...2.9.2) --- updated-dependencies: - dependency-name: apache-airflow dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com> * fix: Update tox.ini (aws#4747) * change: Update README.rst to show conda-forge version of SageMaker SDK (aws#4749) * JumpStart CuratedHub Launch (aws#4748) * Implement CuratedHub APIs (aws#1449) * Implement CuratedHub Admin APIs * making some parameters optional in create_hub_content_reference as per the API design * add describe_hub and list_hubs APIs * implement delete_hub API * Implement list_hub_contents API * create CuratedHub class and supported utils * implement list_models and address comments * Add unit tests * add describe_model function * cache retrieval for describeHubContent changes * fix curated hub class unit tests * add utils needed for curatedHub * Cache retrieval * implement get_hub_model_reference() * cleanup HUB type datatype * cleanup constants * rename list_public_models to list_jumpstart_service_hub_models * implement describe_model_reference * Rename CuratedHub to Hub * address nit * address nits and fix failing tests --------- Co-authored-by: Malav Shastri <malavhs@amazon.com> * feat: implement list_jumpstart_service_hub_models function to fetch JumpStart public hub models (aws#1456) * Implement CuratedHub Admin APIs * making some parameters optional in create_hub_content_reference as per the API design * add describe_hub and list_hubs APIs * implement delete_hub API * Implement list_hub_contents API * create CuratedHub class and supported utils * implement list_models and address comments * Add unit tests * add describe_model function * cache retrieval for describeHubContent changes * fix curated hub class unit tests * add utils needed for curatedHub * Cache retrieval * implement get_hub_model_reference() * cleanup HUB type datatype * cleanup constants * rename list_public_models to list_jumpstart_service_hub_models * implement describe_model_reference * Rename CuratedHub to Hub * address nit * address nits and fix failing tests * implement list_jumpstart_service_hub_models function --------- Co-authored-by: Malav Shastri <malavhs@amazon.com> * Feat/Curated Hub hub_arn and hub_content_type support (aws#1453) * get_model_spec() changes to support hub_arn and hub_content_type * implement get_hub_model_reference() * support hub_arn and hub_content_type for specs retrieval * add support for hub_arn and hub_content_type for serializers, deserializers, estimators, models, predictors and various spec retrieval functionalities * address nits and test failures * remove hub_content_type support --------- Co-authored-by: Malav Shastri <malavhs@amazon.com> * feat: implement curated hub parser and bug bash fixes (aws#1457) * implement HubContentDocument parser * modify the parser to remove aliases for hubcontent documents * bug fix * update boto3 * Bug Fix in the parser * Improve Hub Class and related functionalities * Bug Fix and parser updates * add missing hub_arn support * Add model reference deployment support and other minor bug fixes * fix: retrieve correct image_uri (parser update) * fix: retrieve correct model URI and model data path from HubContentDocument (parser update) * Add model reference deployment support * Model accessor and cache retrival bug fixes * fix: curated hub model training workflow * fix: pass sagemaker sessions object to retrieve model specs from describe_hub_content call * fix: fix payload retrieval for curated hub models * modify constants, enums * fix: update parser * Address nits in the parser * Add unit tests for parser * implement pagination for list_models utility * feat: support wildcard chars for model versions * Address nits and comments * Add Hub Content Arn Tag to training and hosting * Add Hub Content Arn Tag to training and hosting * fix: HubContentDocument schema version * fix broken unit tests * fix prepare_container_def unit tests to include ModelReferenceArn * fix unit tests for test_session.py * revert boto version changes * Fix unit tests * support wildcard model versions for training workflow * Add test cases for get_model_versions * Add/fix unit tests --------- Co-authored-by: Malav Shastri <malavhs@amazon.com> * address unit tests failures in codebuild * change list_jumpstart_service_hub_models to list_sagemaker_public_hub_models() * fix: Changing list input output shapes * fix: gated model training bug * run black -l 100 * flake 8 * address formatting issues * black -l * DocStyle issues * address flake8, pylint * blake -l * pass model type down * disabling pylint for release * disable pylint --------- Co-authored-by: Malav Shastri <malavhs@amazon.com> Co-authored-by: chrstfu <chrstfu@amazon.com> Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com> * prepare release v2.224.1 * update development version to v2.224.2.dev0 * fix: list_models() for python3.8 (aws#4756) * fix: list_models() for python3.8 * fix linting --------- Co-authored-by: Malav Shastri <malavhs@amazon.com> * Update DJLModel class for latest container releases (aws#4754) * simplify and refactor djl model for latest container releases * update model builder for new DJLModel implementation * fix formatting/linting suggestions * update DJLModel documentation on docs site * address reviewer feedback * Feature: Update model card on model package request (aws#4739) * Feature: Update model card on model package request * Feature: Update model card on model package request * fix: update_model_card input types * Feature: register proprietary models from jumpstart (aws#4753) * Feature: register proprietary models from jumpstart Feature: register proprietary models from jumpstart * fix: register jumpstart models on model registry * fixed get_model_id_version_from_endpoint naming issue * fixed issues with model builder * cleanup types.py file * fixed jumpstart unit tests * fixed issue in model_builder --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: ci <ci> Co-authored-by: evakravi <69981223+evakravi@users.noreply.github.com> Co-authored-by: bryannahm1 <110491182+bryannahm1@users.noreply.github.com> Co-authored-by: Bryannah Hernandez <brymh@amazon.com> Co-authored-by: sagemaker-bot <sagemaker-bot@amazon.com> Co-authored-by: Kalyani Nikure <110067132+knikure@users.noreply.github.com> Co-authored-by: Gokul A <166456257+nargokul@users.noreply.github.com> Co-authored-by: Jiao Liu <liujiaor@amazon.com> Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com> Co-authored-by: selvask-aws <selvask@amazon.com> Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com> Co-authored-by: adtian2 <55163384+adtian2@users.noreply.github.com> Co-authored-by: Andrew Tian <tinandr@amazon.com> Co-authored-by: ananth102 <abashyam@amazon.com> Co-authored-by: Jacky Lee <dr.jackylee@gmail.com> Co-authored-by: Jacky Lee <drjacky@amazon.com> Co-authored-by: jiapinw <95885824+jiapinw@users.noreply.github.com> Co-authored-by: Samrudhi Sharma <154457034+samruds@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Malav Shastri <57682969+malav-shastri@users.noreply.github.com> Co-authored-by: Malav Shastri <malavhs@amazon.com> Co-authored-by: chrstfu <chrstfu@amazon.com> Co-authored-by: Siddharth Venkatesan <siddvenk@umich.edu>
Aditi2424
pushed a commit
that referenced
this pull request
Jul 9, 2024
* feat: Benchmark feature initial commit (#1463) * Sync Master benchmark feature (#1461) * feat: support config_name in all JumpStart interfaces (#4583) (#4607) * add-config-name * address comments * updates for set config * docstyle * updates * fix * format * format * remove tests * Add ReadOnly APIs (#4606) * Add ReadOnly APIs * Resolving PR review comments * Resolve PR review comments * Refactoring * Refactoring * Add Caching * Refactore * Resolving conflicts * Add Unit Tests * Fix Unit Tests * Fix unit tests * Fix UT * Refactoring * Fix Integ tests * refactoring after Notebook testing * Fix code styles --------- Co-authored-by: Jonathan Makunga <makung@amazon.com> * feat: tag JumpStart resource with config names (#4608) * tag config name * format * resolving comments * format * format * update * fix * format * updates inference component config name * fix: tests * ModelBuilder: Add functionalities to get and set deployment config. (#4614) * Add funtionalities to get and set deployment config * Resolve PR comments * ModelBuilder-JS * Add Unit tests * Refactoring * Testing with Notebook * Test backward compatibility * Remove Accelerated column if all not enabled * Fix docstring * Resolved PR Review comments * Docstring * increase code coverage --------- Co-authored-by: Jonathan Makunga <makung@amazon.com> * Benchmark feature v2 (#4618) * Add funtionalities to get and set deployment config * Resolve PR comments * ModelBuilder-JS * Add Unit tests * Refactoring * Testing with Notebook * Test backward compatibility * Remove Accelerated column if all not enabled * Fix docstring * Resolved PR Review comments * Docstring * increase code coverage * Testing fix with Notebook * Only fetch instance rate metrics if not present * Increase code coverage --------- Co-authored-by: Jonathan Makunga <makung@amazon.com> * fix: populate default config name to model (#4617) * fix: populate default config name to model * update condition * fix * format * flake8 * fix tests * fix coverage * temporarily skip integ test vulnerbility * fix tolerate attach method * format * fix predictor * format * Fix fetch instance rate bug (#4624) Co-authored-by: Jonathan Makunga <makung@amazon.com> * chore: require config name and instance type in set_deployment_config (#4625) * require config_name and instance_type in set config * docstring * add supported instance types check * add more tests * format * fix tests * Deployment Configs - Follow-ups (#4626) * Init Deployment configs outside Model init. * Testing with NB * Testing with NB-V2 * Refactoring, NB testing * NB Testing and Refactoring * Testing * Refactoring * Testing with NB * Debug * Debug display API * Debug with NB * Testing with NB * Refactoring * Refactoring * Refactoring and NB testing * Testing with NB * Refactoring * Prefix instance type with ml * Fix unit tests --------- Co-authored-by: Jonathan Makunga <makung@amazon.com> * fix: use different separator to flatten dict (#4629) * Use separate tags for inference and training configs (#4635) * Use separate tags for inference and training * format * format * format * format * Add supported inference and incremental training configs (#4637) * supported inference configs * add tests * format * tests * tests * address comments * format and address comments * updates * formt * format * Benchmark feature fixes (#4632) * Filter down Benchmark Metrics * Filter down Benchmark Metrics * Testing NB * Testing MB * Testing * Refactoring * Unit tests * Display instance type first, and instance rate last * Display unbalanced metrics * Testing with NB * Testing with NB * Debug * Debug * Testing with NB * Testing with NB * Testing with NB * Refactoring * Refactoring * Refactoring * Unit tests * Custom lru * Custom lru * Custom lru * Custom lru * Custom lru * Custom lru * Custom lru * Custom lru * Custom lru * Custom lru * Refactoring * Debug * Config ranking * Debug * Debug * Debug * Debug * Debug * Ranking * Ranking-Debug * Ranking-Debug * Ranking-Debug * Ranking-Debug * Ranking-Debug * Ranking-Debug * Debug * Debug * Debug * Debug * Refactoring * Contact JumpStart team to fix flaky test. test_list_jumpstart_models_script_filter --------- Co-authored-by: Jonathan Makunga <makung@amazon.com> * fix: typo and merge with master branch (#4649) * Merge master into benchmark feature (#4652) * Merge master into master-benchmark-feature (#4656) * Master benchmark feature (#4658) * Master benchmark feature merge master (#4661) * Master benchmark feature (#4672) * fix: mainline alt config parsing (#4602) * fix: parsing * fix: commit tests * fix: types * updated * fix * Add Triton v24.03 URI (#4605) Co-authored-by: Nikhil Kulkarni <nikhilsk@amazon.com> * feature: support session tag chaining for training job (#4596) * feature: support session tag chaining for training job * fix: resolve typo * fix: resolve typo and build failure * fix: resolve typo and unit test failure --------- Co-authored-by: Jessica Zhu <jessicazhu3@106775307+jessicazhu3@users.noreply.github.com> * prepare release v2.217.0 * update development version to v2.217.1.dev0 * fix: properly close files in lineage queries and tests (#4587) Closes #4458 * feature: set default allow_pickle param to False (#4557) * breaking: set default allow_pickle param to False * breaking: fix unit tests and linting NumpyDeserializer will not allow deserialization unless allow_pickle flag is set to True explicitly * fix: black-check --------- Co-authored-by: Ashwin Krishna <ashwikri@amazon.com> * Fix:invalid component error with new metadata (#4634) * fix: invalid component name * tests * format * fix vulnerable model integ tests llama 2 * updated * fix: training dataset location * prepare release v2.218.0 * update development version to v2.218.1.dev0 * chore: update skipped flaky tests (#4644) * Update skipped flaky tests * flake8 * format * format * chore: release tgi 2.0.1 (#4642) * chore: release tgi 2.0.1 * minor fix --------- Co-authored-by: Zhaoqi <52220743+zhaoqizqwang@users.noreply.github.com> * fix: Fix UserAgent logging in Python SDK (#4647) * prepare release v2.218.1 * update development version to v2.218.2.dev0 * feature: allow choosing js payload by alias in private method * Updates for SMP v2.3.1 (#4660) Co-authored-by: Suhit Kodgule <skodgule@amazon.com> * chore(deps): bump jinja2 from 3.1.3 to 3.1.4 in /doc (#4655) Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.3 to 3.1.4. - [Release notes](https://github.com/pallets/jinja/releases) - [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst) - [Commits](https://github.com/pallets/jinja/compare/3.1.3...3.1.4) --- updated-dependencies: - dependency-name: jinja2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump tqdm from 4.66.2 to 4.66.3 in /tests/data/serve_resources/mlflow/pytorch (#4650) Bumps [tqdm](https://github.com/tqdm/tqdm) from 4.66.2 to 4.66.3. - [Release notes](https://github.com/tqdm/tqdm/releases) - [Commits](https://github.com/tqdm/tqdm/compare/v4.66.2...v4.66.3) --- updated-dependencies: - dependency-name: tqdm dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump jinja2 from 3.1.3 to 3.1.4 in /requirements/extras (#4654) Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.3 to 3.1.4. - [Release notes](https://github.com/pallets/jinja/releases) - [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst) - [Commits](https://github.com/pallets/jinja/compare/3.1.3...3.1.4) --- updated-dependencies: - dependency-name: jinja2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * prepare release v2.219.0 * update development version to v2.219.1.dev0 * fix: skip flakey tests pending investigation (#4667) * change: update image_uri_configs 05-09-2024 07:17:41 PST * Add tensorflow_serving support for mlflow models and enable lineage tracking for mlflow models (#4662) * Initial commit for tensorflow_serving support of MLflow * Add integ tests for mlflow tf_serving * fix style issues * remove unused attributes from tf builder * Add deep ping for tf_serving local mode * Initial commit for lineage impl * Initial commit for tensorflow_serving support of MLflow * Add integ tests for mlflow tf_serving * fix style issues * remove unused attributes from tf builder * Add deep ping for tf_serving local mode * Add integ tests and uts * fix local mode for tf_serving * Allow lineage tracking only in sagemaker endpoint mode * fix regex pattern * fix style issues * fix regex pattern and hard coded py version in ut * fix missing session * Resolve pr comments and fix regex for mlflow registry and ids * fix: model builder race condition on sagemaker session (#4673) Co-authored-by: Jonathan Makunga <makung@amazon.com> * feat: Add telemetry support for mlflow models (#4674) * Initial commit for telemetry support * Fix style issues and add more logger messages * fix value error messages in ut * feat: add new images for HF TGI release (#4677) * chore: add new images for HF TGI release * test * feature: AutoGluon 1.1.0 image_uris update (#4679) Co-authored-by: Ubuntu <ubuntu@ip-172-31-9-154.us-west-2.compute.internal> * change: add debug logs to workflow container dist creation (#4682) * prepare release v2.220.0 * update development version to v2.220.1.dev0 * fix: Image URI should take precedence for HF models (#4684) * Fix: Image URI should take precedence for HF models * Fix formatting * Fix formatting * Fix formatting * Increase coverage - UT pass * feat: support config_name in all JumpStart interfaces (#4583) (#4607) * add-config-name * address comments * updates for set config * docstyle * updates * fix * format * format * remove tests * Add ReadOnly APIs (#4606) * Add ReadOnly APIs * Resolving PR review comments * Resolve PR review comments * Refactoring * Refactoring * Add Caching * Refactore * Resolving conflicts * Add Unit Tests * Fix Unit Tests * Fix unit tests * Fix UT * Refactoring * Fix Integ tests * refactoring after Notebook testing * Fix code styles --------- Co-authored-by: Jonathan Makunga <makung@amazon.com> * feat: tag JumpStart resource with config names (#4608) * tag config name * format * resolving comments * format * format * update * fix * format * updates inference component config name * fix: tests * ModelBuilder: Add functionalities to get and set deployment config. (#4614) * Add funtionalities to get and set deployment config * Resolve PR comments * ModelBuilder-JS * Add Unit tests * Refactoring * Testing with Notebook * Test backward compatibility * Remove Accelerated column if all not enabled * Fix docstring * Resolved PR Review comments * Docstring * increase code coverage --------- Co-authored-by: Jonathan Makunga <makung@amazon.com> * Benchmark feature v2 (#4618) * Add funtionalities to get and set deployment config * Resolve PR comments * ModelBuilder-JS * Add Unit tests * Refactoring * Testing with Notebook * Test backward compatibility * Remove Accelerated column if all not enabled * Fix docstring * Resolved PR Review comments * Docstring * increase code coverage * Testing fix with Notebook * Only fetch instance rate metrics if not present * Increase code coverage --------- Co-authored-by: Jonathan Makunga <makung@amazon.com> * fix: populate default config name to model (#4617) * fix: populate default config name to model * update condition * fix * format * flake8 * fix tests * fix coverage * temporarily skip integ test vulnerbility * fix tolerate attach method * format * fix predictor * format * Fix fetch instance rate bug (#4624) Co-authored-by: Jonathan Makunga <makung@amazon.com> * chore: require config name and instance type in set_deployment_config (#4625) * require config_name and instance_type in set config * docstring * add supported instance types check * add more tests * format * fix tests * Deployment Configs - Follow-ups (#4626) * Init Deployment configs outside Model init. * Testing with NB * Testing with NB-V2 * Refactoring, NB testing * NB Testing and Refactoring * Testing * Refactoring * Testing with NB * Debug * Debug display API * Debug with NB * Testing with NB * Refactoring * Refactoring * Refactoring and NB testing * Testing with NB * Refactoring * Prefix instance type with ml * Fix unit tests --------- Co-authored-by: Jonathan Makunga <makung@amazon.com> * fix: use different separator to flatten dict (#4629) * Use separate tags for inference and training configs (#4635) * Use separate tags for inference and training * format * format * format * format * Add supported inference and incremental training configs (#4637) * supported inference configs * add tests * format * tests * tests * address comments * format and address comments * updates * formt * format * Benchmark feature fixes (#4632) * Filter down Benchmark Metrics * Filter down Benchmark Metrics * Testing NB * Testing MB * Testing * Refactoring * Unit tests * Display instance type first, and instance rate last * Display unbalanced metrics * Testing with NB * Testing with NB * Debug * Debug * Testing with NB * Testing with NB * Testing with NB * Refactoring * Refactoring * Refactoring * Unit tests * Custom lru * Custom lru * Custom lru * Custom lru * Custom lru * Custom lru * Custom lru * Custom lru * Custom lru * Custom lru * Refactoring * Debug * Config ranking * Debug * Debug * Debug * Debug * Debug * Ranking * Ranking-Debug * Ranking-Debug * Ranking-Debug * Ranking-Debug * Ranking-Debug * Ranking-Debug * Debug * Debug * Debug * Debug * Refactoring * Contact JumpStart team to fix flaky test. test_list_jumpstart_models_script_filter --------- Co-authored-by: Jonathan Makunga <makung@amazon.com> * fix: typo and merge with master branch (#4649) * Merge master into benchmark feature (#4652) * Merge master into master-benchmark-feature (#4656) * Master benchmark feature (#4658) * Remove duplicate line in types.py * Remove duplicate lines * Remove duplicate lines * Remove duplicate lines * Remove duplicate lines * fix unit test --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Haotian An <33510317+Captainia@users.noreply.github.com> Co-authored-by: Nikhil Kulkarni <knikhil29@gmail.com> Co-authored-by: Nikhil Kulkarni <nikhilsk@amazon.com> Co-authored-by: jessicazhu3 <106775307+jessicazhu3@users.noreply.github.com> Co-authored-by: Jessica Zhu <jessicazhu3@106775307+jessicazhu3@users.noreply.github.com> Co-authored-by: ci <ci> Co-authored-by: Justin <justinm088@hotmail.com> Co-authored-by: ASHWIN KRISHNA <38850354+akrishna1995@users.noreply.github.com> Co-authored-by: Ashwin Krishna <ashwikri@amazon.com> Co-authored-by: Haixin Wang <98612668+haixiw@users.noreply.github.com> Co-authored-by: Zhaoqi <52220743+zhaoqizqwang@users.noreply.github.com> Co-authored-by: Kalyani Nikure <110067132+knikure@users.noreply.github.com> Co-authored-by: Keerthan Vasist <kvasist@amazon.com> Co-authored-by: SuhitK <kodgule.suhit@gmail.com> Co-authored-by: Suhit Kodgule <skodgule@amazon.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: sagemaker-bot <sagemaker-bot@amazon.com> Co-authored-by: jiapinw <95885824+jiapinw@users.noreply.github.com> Co-authored-by: Jonathan Makunga <54963715+makungaj1@users.noreply.github.com> Co-authored-by: Jonathan Makunga <makung@amazon.com> Co-authored-by: Prateek M Desai <prateekmdesai04@gmail.com> Co-authored-by: Ubuntu <ubuntu@ip-172-31-9-154.us-west-2.compute.internal> Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com> Co-authored-by: Samrudhi Sharma <154457034+samruds@users.noreply.github.com> Co-authored-by: evakravi <69981223+evakravi@users.noreply.github.com> * fix benchmark feature read-only apis (#4675) * Rearrange benchmark metric table * Refactoring * Refactoring * Refactoring * Refactoring * Debug * Debug * Debug * Debug * Debug * Debug * Debug * Debug * Debug * Debug * Debug * Debug * Debug * Debug * Debug * Debug * Debug * Refactoring * Refactoring * Refactoring * Refactoring * Refactoring * Add Unit tests * Refactoring * Refactoring * hide index from DataFrame --------- Co-authored-by: Jonathan Makunga <makung@amazon.com> * feat: update alt config to work with model packages (#4706) * feat: update alt config to work with model packages * format * remove env vars for model package * fix tests * Update: ReadOnly APIs (#4707) * Model data arn * Refactoring * Refactoring * acceleration_configs * Refactoring * UT * Add Filter * UT * Revert "UT" * UT * UT --------- Co-authored-by: Jonathan Makunga <makung@amazon.com> * ModelBuilder to support display with filter. (#4712) Co-authored-by: Jonathan Makunga <makung@amazon.com> * Sync branch (#4718) * fix: mainline alt config parsing (#4602) * fix: parsing * fix: commit tests * fix: types * updated * fix * Add Triton v24.03 URI (#4605) Co-authored-by: Nikhil Kulkarni <nikhilsk@amazon.com> * feature: support session tag chaining for training job (#4596) * feature: support session tag chaining for training job * fix: resolve typo * fix: resolve typo and build failure * fix: resolve typo and unit test failure --------- Co-authored-by: Jessica Zhu <jessicazhu3@106775307+jessicazhu3@users.noreply.github.com> * prepare release v2.217.0 * update development version to v2.217.1.dev0 * fix: properly close files in lineage queries and tests (#4587) Closes #4458 * feature: set default allow_pickle param to False (#4557) * breaking: set default allow_pickle param to False * breaking: fix unit tests and linting NumpyDeserializer will not allow deserialization unless allow_pickle flag is set to True explicitly * fix: black-check --------- Co-authored-by: Ashwin Krishna <ashwikri@amazon.com> * Fix:invalid component error with new metadata (#4634) * fix: invalid component name * tests * format * fix vulnerable model integ tests llama 2 * updated * fix: training dataset location * prepare release v2.218.0 * update development version to v2.218.1.dev0 * chore: update skipped flaky tests (#4644) * Update skipped flaky tests * flake8 * format * format * chore: release tgi 2.0.1 (#4642) * chore: release tgi 2.0.1 * minor fix --------- Co-authored-by: Zhaoqi <52220743+zhaoqizqwang@users.noreply.github.com> * fix: Fix UserAgent logging in Python SDK (#4647) * prepare release v2.218.1 * update development version to v2.218.2.dev0 * feature: allow choosing js payload by alias in private method * Updates for SMP v2.3.1 (#4660) Co-authored-by: Suhit Kodgule <skodgule@amazon.com> * chore(deps): bump jinja2 from 3.1.3 to 3.1.4 in /doc (#4655) Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.3 to 3.1.4. - [Release notes](https://github.com/pallets/jinja/releases) - [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst) - [Commits](https://github.com/pallets/jinja/compare/3.1.3...3.1.4) --- updated-dependencies: - dependency-name: jinja2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump tqdm from 4.66.2 to 4.66.3 in /tests/data/serve_resources/mlflow/pytorch (#4650) Bumps [tqdm](https://github.com/tqdm/tqdm) from 4.66.2 to 4.66.3. - [Release notes](https://github.com/tqdm/tqdm/releases) - [Commits](https://github.com/tqdm/tqdm/compare/v4.66.2...v4.66.3) --- updated-dependencies: - dependency-name: tqdm dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump jinja2 from 3.1.3 to 3.1.4 in /requirements/extras (#4654) Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.3 to 3.1.4. - [Release notes](https://github.com/pallets/jinja/releases) - [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst) - [Commits](https://github.com/pallets/jinja/compare/3.1.3...3.1.4) --- updated-dependencies: - dependency-name: jinja2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * prepare release v2.219.0 * update development version to v2.219.1.dev0 * fix: skip flakey tests pending investigation (#4667) * change: update image_uri_configs 05-09-2024 07:17:41 PST * Add tensorflow_serving support for mlflow models and enable lineage tracking for mlflow models (#4662) * Initial commit for tensorflow_serving support of MLflow * Add integ tests for mlflow tf_serving * fix style issues * remove unused attributes from tf builder * Add deep ping for tf_serving local mode * Initial commit for lineage impl * Initial commit for tensorflow_serving support of MLflow * Add integ tests for mlflow tf_serving * fix style issues * remove unused attributes from tf builder * Add deep ping for tf_serving local mode * Add integ tests and uts * fix local mode for tf_serving * Allow lineage tracking only in sagemaker endpoint mode * fix regex pattern * fix style issues * fix regex pattern and hard coded py version in ut * fix missing session * Resolve pr comments and fix regex for mlflow registry and ids * fix: model builder race condition on sagemaker session (#4673) Co-authored-by: Jonathan Makunga <makung@amazon.com> * feat: Add telemetry support for mlflow models (#4674) * Initial commit for telemetry support * Fix style issues and add more logger messages * fix value error messages in ut * feat: add new images for HF TGI release (#4677) * chore: add new images for HF TGI release * test * feature: AutoGluon 1.1.0 image_uris update (#4679) Co-authored-by: Ubuntu <ubuntu@ip-172-31-9-154.us-west-2.compute.internal> * change: add debug logs to workflow container dist creation (#4682) * prepare release v2.220.0 * update development version to v2.220.1.dev0 * fix: Image URI should take precedence for HF models (#4684) * Fix: Image URI should take precedence for HF models * Fix formatting * Fix formatting * Fix formatting * Increase coverage - UT pass * feat: onboard tei image config to pysdk (#4681) * feat: onboard tei image config to pysdk * fix formatting issue * minor fix func name * fix unit tests --------- Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com> * fix: model builder limited container support for endpoint mode. (#4683) * Allow ModelBuilder's endpoint mode for Jumpstart models packaged with containers other than TGI and DJL * increase coverage * Add JS Support for MMS Serving * Add JS Support for MMS Serving * Unit tests * Refactoring * Refactoring * Refactoring --------- Co-authored-by: Jonathan Makunga <makung@amazon.com> * change: Add more debuging (#4687) * change: cover tei with image_uris.retrieve API (#4689) * fix: JS Model with non-TGI/non-DJL deployment failure (#4688) * Debug * Debug * Debug * Debug * Debug * Debug * fix docstyle * Refactoring * Add Integ tests --------- Co-authored-by: Jonathan Makunga <makung@amazon.com> * Feat: Pull latest tei container for sentence similiarity models on HuggingFace hub (#4686) * Update: Pull latest tei container for sentence similiarity models * Fix formatting * Address PR comments * Fix formatting * Fix check * Switch sentence similarity to be deployed on tgi * Fix formatting * Fix formatting * Fix formatting * Fix formatting * Introduce TEI builder with TGI server * Fix formmatting * Add integ test * Fix formatting * Add integ test * Add integ test * Add integ test * Add integ test * Add integ test * Fix formatting * Move to G5 for integ test * Fix formatting * Integ test updates * Integ test updates * Integ test updates * Fix formatting * Integ test updates * Move back to generate for ping * Integ test updates * Integ test updates * Fix: Add Image URI overrides for transformers models (#4693) * Fix: Add Image URI overrides for transformers models * Increase coverage * Fix formatting * prepare release v2.221.0 * update development version to v2.221.1.dev0 * Add tei cpu image (#4695) * Add tei cpu image * fix format issue * fix unit tests * fix typo * fix typo * Feat: Add TEI support for ModelBuilder (#4694) * Add TEI Serving * Add TEI Serving * Add TEI Serving * Add TEI Serving * Add TEI Serving * Add TEI Serving * Notebook testing * Notebook testing * Notebook testing * Refactoring * Refactoring * UT * UT * Refactoring * Test coverage * Refactoring * Refactoring --------- Co-authored-by: Jonathan Makunga <makung@amazon.com> * Convert pytorchddp distribution to smdistributed distribution (#4698) * rewrite pytorchddp to smdistributed * remove instance type check * Update estimator.py * remove validate_pytorch_distribution * fix * fix unit tests * fix formatting * check instance type not None * prepare release v2.221.1 * update development version to v2.221.2.dev0 * Update: SM Endpoint Routing Strategy Support. (#4702) * RoutingConfig * Refactoring * Docstring * UT * Refactoring * Refactoring --------- Co-authored-by: Jonathan Makunga <makung@amazon.com> * change: update image_uri_configs 05-29-2024 07:17:35 PST * Making project name in workflow files dynamic (#4708) * fix: Fix ci unit-tests (#4713) * chore(deps): bump requests from 2.31.0 to 2.32.2 in /tests/data/serve_resources/mlflow/pytorch (#4709) Bumps [requests](https://github.com/psf/requests) from 2.31.0 to 2.32.2. - [Release notes](https://github.com/psf/requests/releases) - [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md) - [Commits](https://github.com/psf/requests/compare/v2.31.0...v2.32.2) --- updated-dependencies: - dependency-name: requests dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump apache-airflow from 2.9.0 to 2.9.1 in /requirements/extras (#4703) * chore(deps): bump apache-airflow in /requirements/extras Bumps [apache-airflow](https://github.com/apache/airflow) from 2.9.0 to 2.9.1. - [Release notes](https://github.com/apache/airflow/releases) - [Changelog](https://github.com/apache/airflow/blob/main/RELEASE_NOTES.rst) - [Commits](https://github.com/apache/airflow/compare/2.9.0...2.9.1) --- updated-dependencies: - dependency-name: apache-airflow dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Update tox.ini to bump apache-airflow --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kalyani Nikure <110067132+knikure@users.noreply.github.com> * chore(deps): bump mlflow from 2.10.2 to 2.12.1 in /tests/data/serve_resources/mlflow/pytorch (#4690) Bumps [mlflow](https://github.com/mlflow/mlflow) from 2.10.2 to 2.12.1. - [Release notes](https://github.com/mlflow/mlflow/releases) - [Changelog](https://github.com/mlflow/mlflow/blob/master/CHANGELOG.md) - [Commits](https://github.com/mlflow/mlflow/compare/v2.10.2...v2.12.1) --- updated-dependencies: - dependency-name: mlflow dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump mlflow from 2.11.1 to 2.12.1 in /tests/data/serve_resources/mlflow/xgboost (#4692) Bumps [mlflow](https://github.com/mlflow/mlflow) from 2.11.1 to 2.12.1. - [Release notes](https://github.com/mlflow/mlflow/releases) - [Changelog](https://github.com/mlflow/mlflow/blob/master/CHANGELOG.md) - [Commits](https://github.com/mlflow/mlflow/compare/v2.11.1...v2.12.1) --- updated-dependencies: - dependency-name: mlflow dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump mlflow from 2.11.1 to 2.12.1 in /tests/data/serve_resources/mlflow/tensorflow (#4691) Bumps [mlflow](https://github.com/mlflow/mlflow) from 2.11.1 to 2.12.1. - [Release notes](https://github.com/mlflow/mlflow/releases) - [Changelog](https://github.com/mlflow/mlflow/blob/master/CHANGELOG.md) - [Commits](https://github.com/mlflow/mlflow/compare/v2.11.1...v2.12.1) --- updated-dependencies: - dependency-name: mlflow dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * change: Updates for DJL 0.28.0 release (#4701) * Sync Branch --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Haotian An <33510317+Captainia@users.noreply.github.com> Co-authored-by: Nikhil Kulkarni <knikhil29@gmail.com> Co-authored-by: Nikhil Kulkarni <nikhilsk@amazon.com> Co-authored-by: jessicazhu3 <106775307+jessicazhu3@users.noreply.github.com> Co-authored-by: Jessica Zhu <jessicazhu3@106775307+jessicazhu3@users.noreply.github.com> Co-authored-by: ci <ci> Co-authored-by: Justin <justinm088@hotmail.com> Co-authored-by: ASHWIN KRISHNA <38850354+akrishna1995@users.noreply.github.com> Co-authored-by: Ashwin Krishna <ashwikri@amazon.com> Co-authored-by: Haixin Wang <98612668+haixiw@users.noreply.github.com> Co-authored-by: Zhaoqi <52220743+zhaoqizqwang@users.noreply.github.com> Co-authored-by: Kalyani Nikure <110067132+knikure@users.noreply.github.com> Co-authored-by: Keerthan Vasist <kvasist@amazon.com> Co-authored-by: SuhitK <kodgule.suhit@gmail.com> Co-authored-by: Suhit Kodgule <skodgule@amazon.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: sagemaker-bot <sagemaker-bot@amazon.com> Co-authored-by: jiapinw <95885824+jiapinw@users.noreply.github.com> Co-authored-by: Jonathan Makunga <makung@amazon.com> Co-authored-by: Prateek M Desai <prateekmdesai04@gmail.com> Co-authored-by: Ubuntu <ubuntu@ip-172-31-9-154.us-west-2.compute.internal> Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com> Co-authored-by: Samrudhi Sharma <154457034+samruds@users.noreply.github.com> Co-authored-by: Tom Bousso <tombousso@gmail.com> Co-authored-by: Zhaoqi <jzhaoqwa@amazon.com> Co-authored-by: Tyler Osterberg <tyoster@amazon.com> * Merge --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Haotian An <33510317+Captainia@users.noreply.github.com> Co-authored-by: Jonathan Makunga <makung@amazon.com> Co-authored-by: evakravi <69981223+evakravi@users.noreply.github.com> Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com> Co-authored-by: Nikhil Kulkarni <knikhil29@gmail.com> Co-authored-by: Nikhil Kulkarni <nikhilsk@amazon.com> Co-authored-by: jessicazhu3 <106775307+jessicazhu3@users.noreply.github.com> Co-authored-by: Jessica Zhu <jessicazhu3@106775307+jessicazhu3@users.noreply.github.com> Co-authored-by: Justin <justinm088@hotmail.com> Co-authored-by: ASHWIN KRISHNA <38850354+akrishna1995@users.noreply.github.com> Co-authored-by: Ashwin Krishna <ashwikri@amazon.com> Co-authored-by: Haixin Wang <98612668+haixiw@users.noreply.github.com> Co-authored-by: Zhaoqi <52220743+zhaoqizqwang@users.noreply.github.com> Co-authored-by: Kalyani Nikure <110067132+knikure@users.noreply.github.com> Co-authored-by: Keerthan Vasist <kvasist@amazon.com> Co-authored-by: SuhitK <kodgule.suhit@gmail.com> Co-authored-by: Suhit Kodgule <skodgule@amazon.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: sagemaker-bot <sagemaker-bot@amazon.com> Co-authored-by: jiapinw <95885824+jiapinw@users.noreply.github.com> Co-authored-by: Prateek M Desai <prateekmdesai04@gmail.com> Co-authored-by: Ubuntu <ubuntu@ip-172-31-9-154.us-west-2.compute.internal> Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com> Co-authored-by: Samrudhi Sharma <154457034+samruds@users.noreply.github.com> Co-authored-by: Tom Bousso <tombousso@gmail.com> Co-authored-by: Zhaoqi <jzhaoqwa@amazon.com> Co-authored-by: Tyler Osterberg <tyoster@amazon.com> * Fix UT (#1465) Co-authored-by: Jonathan Makunga <makung@amazon.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Jonathan Makunga <54963715+makungaj1@users.noreply.github.com> Co-authored-by: Haotian An <33510317+Captainia@users.noreply.github.com> Co-authored-by: Jonathan Makunga <makung@amazon.com> Co-authored-by: evakravi <69981223+evakravi@users.noreply.github.com> Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com> Co-authored-by: Nikhil Kulkarni <knikhil29@gmail.com> Co-authored-by: Nikhil Kulkarni <nikhilsk@amazon.com> Co-authored-by: jessicazhu3 <106775307+jessicazhu3@users.noreply.github.com> Co-authored-by: Jessica Zhu <jessicazhu3@106775307+jessicazhu3@users.noreply.github.com> Co-authored-by: Justin <justinm088@hotmail.com> Co-authored-by: ASHWIN KRISHNA <38850354+akrishna1995@users.noreply.github.com> Co-authored-by: Ashwin Krishna <ashwikri@amazon.com> Co-authored-by: Haixin Wang <98612668+haixiw@users.noreply.github.com> Co-authored-by: Zhaoqi <52220743+zhaoqizqwang@users.noreply.github.com> Co-authored-by: Keerthan Vasist <kvasist@amazon.com> Co-authored-by: SuhitK <kodgule.suhit@gmail.com> Co-authored-by: Suhit Kodgule <skodgule@amazon.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: sagemaker-bot <sagemaker-bot@amazon.com> Co-authored-by: jiapinw <95885824+jiapinw@users.noreply.github.com> Co-authored-by: Prateek M Desai <prateekmdesai04@gmail.com> Co-authored-by: Ubuntu <ubuntu@ip-172-31-9-154.us-west-2.compute.internal> Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com> Co-authored-by: Samrudhi Sharma <154457034+samruds@users.noreply.github.com> Co-authored-by: Tom Bousso <tombousso@gmail.com> Co-authored-by: Zhaoqi <jzhaoqwa@amazon.com> Co-authored-by: Tyler Osterberg <tyoster@amazon.com> * feat: Model class to support AdditionalModelDataSources (#1469) * Add support for AdditionalModelDataSources * Resolve PR comments * Resolve PR comments * Resolve PR comments * fix unit tests * Resolve PR comments --------- Co-authored-by: Jonathan Makunga <makung@amazon.com> * feat: additional hosting model data source parsing (#1467) * feat: Additional Model Data source parsing * address comments * address comments * format * Add optimize to ModelBuilder (#1468) * Add optimize to ModelBuilder * Add polling for job completion * fix UTs --------- Co-authored-by: Jacky Lee <drjacky@amazon.com> * feat: Added utils for extracting JS data sources (#1471) * added utils for accessing hosting data sources * added utils for accessing hosting data sources * removed other changes * fixed formatting issues * remove .keys() * updated JumpStartModelDataSource * fix slots * remove print * fix tests * update tests * fix: update passing additional model data sources to API (#1472) * feat: Added utils for extracting JS data sources (#1471) * added utils for accessing hosting data sources * added utils for accessing hosting data sources * removed other changes * fixed formatting issues * remove .keys() * updated JumpStartModelDataSource * fix slots * remove print * fix tests * update tests * fix: update passing additional model data sources to API * format * format * format * format and address comments * format * format * format --------- Co-authored-by: Adam Kozdrowicz <akozdrowicz@gmail.com> * fix: overriding instance specific fields in config components (#1478) * fix: instance specific variables override * format * Feat: Add optimize to ModelBuilder JS (#1474) * QS JS vanilla model * Use Alt config for Optimization * JS Optimize * Resolve config * inject additional tags * Inject tags * Refactoring * Refactoring * Filter Deployment config * Refactoring * Refactoring * Refactoring * Refactoring --------- Co-authored-by: Jonathan Makunga <makung@amazon.com> * feat: use Neo bucket in speculative decoding data source (#1479) * Use Neo bucket in speculative decoding data source * address comments * format * address comments * add buckets to regional config * remove opt-in regions for neo buckets * feat: add build/deploy support for fine-tuned JS models (#1473) * feat: add support for fine-tuned JS models * Refactor * Refactor * Refactor * Refactor * pylint * pylint --------- Co-authored-by: Jacky Lee <drjacky@amazon.com> * update: Add optimize to ModelBuilder JS (#1480) * Testing with Notebook * Refactoring * _poll_optimization_job refactoring * Resolve PR Comments * Refactoring * Refactoring * refactoring * Fix conflicts * Notebook testing * Refactoring * Refactoring --------- Co-authored-by: Jonathan Makunga <makung@amazon.com> * update: Add optimize to ModelBuilder JS (#1485) * MB JS Optimize * UT * Refactore * UT * UT * refactore * refactore --------- Co-authored-by: Jonathan Makunga <makung@amazon.com> * feat: add quicksilver telemetry (#1482) * feat: add quicksilver telemetry fields * pylint * add UTs * pylint * Refactor * add gated and fine-tuned to telemetry * fix: typo * fix: jumpstart var * refactor model_hub * pylint * update TEI/TGI to remove jumpstart field * reorder telemetry schema * refactor --------- Co-authored-by: Jacky Lee <drjacky@amazon.com> * unit: tests for fine tuned JS model support (#1481) * UTs * flake8 --------- Co-authored-by: Jacky Lee <drjacky@amazon.com> * fix: use current session and role when setting config (#1493) * fix: use current session and role when setting config * format * fix: training arn support (#1494) * fix: training job ARN * pylint --------- Co-authored-by: Jacky Lee <drjacky@amazon.com> * Bug bash fixes (#1492) * HF Optimized * Revert "HF Optimized" * MB HF Optimize support * Refactoring * HF only s3 upload if optimize * reuse role if provided in MB * Refactoring * New requirements * Draft * Refactoring * Refactoring * Bug Bash fixes * UT * UT * Fix for parsing optimization output * Tag fix * UT * UT --------- Co-authored-by: Jonathan Makunga <makung@amazon.com> * Bug fixes (#1496) * Bug fixes * refcatore * ENV update * Remove code duplication * Fix Integ tests * Fix MB EULA bug --------- Co-authored-by: Jonathan Makunga <makung@amazon.com> * JS Optimize api ref * Refactoring * Refactoring * Fix issues * Channel name * Channel name * Optimization output * neuron model env * Merge master into master-benchmark-feature (#1502) * prepare release v2.222.0 * update development version to v2.222.1.dev0 * fix: estimator.deploy not respecting instance type (#4724) * fix: estimator.deploy not respecting instance type * chore: add inline comment about using user supplied instance type * First changes (#4723) Co-authored-by: Bryannah Hernandez <brymh@amazon.com> * prepare release v2.222.1 * update development version to v2.222.2.dev0 * change: update image_uri_configs 06-12-2024 07:17:03 PST * fix: Fix ci unit-tests (#4728) * Implement custom telemetry logging in SDK (#4721) * Fix Sniping bug fix (#4730) * Python SDK bucket sniping fix bug * Python SDK bucket sniping fix bug * Minor fixes to default bucket function and fixing unit tests * fix - Fixes from Pylint failures * fix - Fixes from Flake8 failures * fix - More Flake8 fixes * fix - Remove Whitespace from blankline * fix - Fix black recommendations * fix - Adjust tabbing --------- Co-authored-by: Jiao Liu <liujiaor@amazon.com> Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com> * feature: add 'ModelCard' property to Register step (#4726) * feature: add 'ModelCard' property to RegisterModel step * Updated ModelCard content type * fix: ModelCard Object integ Test fix --------- Co-authored-by: Gokul A <166456257+nargokul@users.noreply.github.com> * prepare release v2.223.0 * update development version to v2.223.1.dev0 * Fix Dependabot Issues - MLFlow Version (#4731) * fix - Address Dependapot issues * fix -Update MLFLOW Version * Fix: AttributeError: 'NoneType' object has no attribute 'len' error in session.py (#4735) * fix - Address Dependapot issues * fix -Update MLFLOW Version * fix - Update fetching Length for NoneType Error * change: Enable telemetry logging for Remote function (#4729) * change: Enhance telemetry logging module and feature coverage * Fix default session issue * fix unit-tests * chore: use ml.g5.2xlarge for integ test (#4741) * feat: JumpStartModel attach (#4680) * feat: JumpStartModel attach * fix: unit tests * chore: change order of kwargs to pass unit tests * chore: update docstrings, add tests * fix: docstring * fix: integ tests * chore: address PR comments --------- Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com> * Upgrading to PT 2.3 for release (#4732) * upgrading to PT 2.3 for release * reverting mistake in modifying dataparallel --------- Co-authored-by: Andrew Tian <tinandr@amazon.com> Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com> * feat(sagemaker-mlflow): New features for SageMaker MLflow (#4744) * feat: add support for mlflow inputs (#1441) * feat: add support for mlflow inputs * fix: typo * fix: doc * fix: S3 regex * fix: refactor * fix: refactor typo * fix: pylint * fix: pylint * fix: black and pylint --------- Co-authored-by: Jacky Lee <drjacky@amazon.com> * fix: lineage tracking bug (#1447) * fix: lineage bug * fix: lineage * fix: add validation for tracking ARN input with MLflow input type * fix: bug * fix: unit tests * fix: mock * fix: args --------- Co-authored-by: Jacky Lee <drjacky@amazon.com> * [Fix] regex for RunId to handle empty artifact path and change mlflow plugin name (#1455) * [Fix] run id regex pattern such that empty artifact path is handled * Change mlflow plugin name as per legal team requirement * Update describe_mlflow_tracking_server call to align with api changes (#1466) * feat: (sagemaker-mlflow) Adding Presigned Url function to SDK (#1462) (#1477) * mlflow presigned url changes * addressing design feedback * test changes * change: mlflow plugin name (#1489) Co-authored-by: Jacky Lee <drjacky@amazon.com> --------- Co-authored-by: Jacky Lee <dr.jackylee@gmail.com> Co-authored-by: Jacky Lee <drjacky@amazon.com> Co-authored-by: jiapinw <95885824+jiapinw@users.noreply.github.com> Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com> * prepare release v2.224.0 * update development version to v2.224.1.dev0 * fix: Model server override logic (#4733) * fix: Model server override logic * Fix formatting --------- Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com> * chore(deps): bump apache-airflow from 2.9.1 to 2.9.2 in /requirements/extras (#4740) Bumps [apache-airflow](https://github.com/apache/airflow) from 2.9.1 to 2.9.2. - [Release notes](https://github.com/apache/airflow/releases) - [Changelog](https://github.com/apache/airflow/blob/main/RELEASE_NOTES.rst) - [Commits](https://github.com/apache/airflow/compare/2.9.1...2.9.2) --- updated-dependencies: - dependency-name: apache-airflow dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com> * fix: Update tox.ini (#4747) * change: Update README.rst to show conda-forge version of SageMaker SDK (#4749) * JumpStart CuratedHub Launch (#4748) * Implement CuratedHub APIs (#1449) * Implement CuratedHub Admin APIs * making some parameters optional in create_hub_content_reference as per the API design * add describe_hub and list_hubs APIs * implement delete_hub API * Implement list_hub_contents API * create CuratedHub class and supported utils * implement list_models and address comments * Add unit tests * add describe_model function * cache retrieval for describeHubContent changes * fix curated hub class unit tests * add utils needed for curatedHub * Cache retrieval * implement get_hub_model_reference() * cleanup HUB type datatype * cleanup constants * rename list_public_models to list_jumpstart_service_hub_models * implement describe_model_reference * Rename CuratedHub to Hub * address nit * address nits and fix failing tests --------- Co-authored-by: Malav Shastri <malavhs@amazon.com> * feat: implement list_jumpstart_service_hub_models function to fetch JumpStart public hub models (#1456) * Implement CuratedHub Admin APIs * making some parameters optional in create_hub_content_reference as per the API design * add describe_hub and list_hubs APIs * implement delete_hub API * Implement list_hub_contents API * create CuratedHub class and supported utils * implement list_models and address comments * Add unit tests * add describe_model function * cache retrieval for describeHubContent changes * fix curated hub class unit tests * add utils needed for curatedHub * Cache retrieval * implement get_hub_model_reference() * cleanup HUB type datatype * cleanup constants * rename list_public_models to list_jumpstart_service_hub_models * implement describe_model_reference * Rename CuratedHub to Hub * address nit * address nits and fix failing tests * implement list_jumpstart_service_hub_models function --------- Co-authored-by: Malav Shastri <malavhs@amazon.com> * Feat/Curated Hub hub_arn and hub_content_type support (#1453) * get_model_spec() changes to support hub_arn and hub_content_type * implement get_hub_model_reference() * support hub_arn and hub_content_type for specs retrieval * add support for hub_arn and hub_content_type for serializers, deserializers, estimators, models, predictors and various spec retrieval functionalities * address nits and test failures * remove hub_content_type support --------- Co-authored-by: Malav Shastri <malavhs@amazon.com> * feat: implement curated hub parser and bug bash fixes (#1457) * implement HubContentDocument parser * modify the parser to remove aliases for hubcontent documents * bug fix * update boto3 * Bug Fix in the parser * Improve Hub Class and related functionalities * Bug Fix and parser updates * add missing hub_arn support * Add model reference deployment support and other minor bug fixes * fix: retrieve correct image_uri (parser update) * fix: retrieve correct model URI and model data path from HubContentDocument (parser update) * Add model reference deployment support * Model accessor and cache retrival bug fixes * fix: curated hub model training workflow * fix: pass sagemaker sessions object to retrieve model specs from describe_hub_content call * fix: fix payload retrieval for curated hub models * modify constants, enums * fix: update parser * Address nits in the parser * Add unit tests for parser * implement pagination for list_models utility * feat: support wildcard chars for model versions * Address nits and comments * Add Hub Content Arn Tag to training and hosting * Add Hub Content Arn Tag to training and hosting * fix: HubContentDocument schema version * fix broken unit tests * fix prepare_container_def unit tests to include ModelReferenceArn * fix unit tests for test_session.py * revert boto version changes * Fix unit tests * support wildcard model versions for training workflow * Add test cases for get_model_versions * Add/fix unit tests --------- Co-authored-by: Malav Shastri <malavhs@amazon.com> * address unit tests failures in codebuild * change list_jumpstart_service_hub_models to list_sagemaker_public_hub_models() * fix: Changing list input output shapes * fix: gated model training bug * run black -l 100 * flake 8 * address formatting issues * black -l * DocStyle issues * address flake8, pylint * blake -l * pass model type down * disabling pylint for release * disable pylint --------- Co-authored-by: Malav Shastri <malavhs@amazon.com> Co-authored-by: chrstfu <chrstfu@amazon.com> Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com> * prepare release v2.224.1 * update development version to v2.224.2.dev0 * fix: list_models() for python3.8 (#4756) * fix: list_models() for python3.8 * fix linting --------- Co-authored-by: Malav Shastri <malavhs@amazon.com> * Update DJLModel class for latest container releases (#4754) * simplify and refactor djl model for latest container releases * update model builder for new DJLModel implementation * fix formatting/linting suggestions * update DJLModel documentation on docs site * address reviewer feedback * Feature: Update model card on model package request (#4739) * Feature: Update model card on model package request * Feature: Update model card on model package request * fix: update_model_card input types * Feature: register proprietary models from jumpstart (#4753) * Feature: register proprietary models from jumpstart Feature: register proprietary models from jumpstart * fix: register jumpstart models on model registry * fixed get_model_id_version_from_endpoint naming issue * fixed issues with model builder * cleanup types.py file * fixed jumpstart unit tests * fixed issue in model_builder --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: ci <ci> Co-authored-by: evakravi <69981223+evakravi@users.noreply.github.com> Co-authored-by: bryannahm1 <110491182+bryannahm1@users.noreply.github.com> Co-authored-by: Bryannah Hernandez <brymh@amazon.com> Co-authored-by: sagemaker-bot <sagemaker-bot@amazon.com> Co-authored-by: Kalyani Nikure <110067132+knikure@users.noreply.github.com> Co-authored-by: Gokul A <166456257+nargokul@users.noreply.github.com> Co-authored-by: Jiao Liu <liujiaor@amazon.com> Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com> Co-authored-by: selvask-aws <selvask@amazon.com> Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com> Co-authored-by: adtian2 <55163384+adtian2@users.noreply.github.com> Co-authored-by: Andrew Tian <tinandr@amazon.com> Co-authored-by: ananth102 <abashyam@amazon.com> Co-authored-by: Jacky Lee <dr.jackylee@gmail.com> Co-authored-by: Jacky Lee <drjacky@amazon.com> Co-authored-by: jiapinw <95885824+jiapinw@users.noreply.github.com> Co-authored-by: Samrudhi Sharma <154457034+samruds@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Malav Shastri <57682969+malav-shastri@users.noreply.github.com> Co-authored-by: Malav Shastri <malavhs@amazon.com> Co-authored-by: chrstfu <chrstfu@amazon.com> Co-authored-by: Siddharth Venkatesan <siddvenk@umich.edu> * feat: Support Alt Configs for Public & Curated Hub (#1505) * feat: add alt config support for public & curated hub * fix: make telemetry logger persist certain information (#1500) * refactor telemetry logger * refactor * refactor * pylint + UT * add tag * add remove tags * handle tags again * pylint --------- Co-authored-by: Jacky Lee <drjacky@amazon.com> * Optimize support for hf models (#1499) * HF support * refactoring * Refactoring * Refactoing * HF Refactoring * Refactoring * UT * Fix UT * Resolving PR comments * HF Token * Resolving PR comments * Fix UT * Fix JS ModelServer deploy wrapper override * Fix tests * fix UT * Resolve PR comments * fix doc --------- Co-authored-by: Jonathan Makunga <makung@amazon.com> * Fixing bugs (#1506) * Fixing bugs * Refactoring * Increase coverage * Fix UT * Fix UT * Increase coverage * Fix UT * Refactoring * Fix UT --------- Co-authored-by: Jonathan Makunga <makung@amazon.com> * Fix public optimize api signature (#1507) * Fix public optimize api signature * JS Compilation fix * Refactoring * Refactoring --------- Co-authored-by: Jonathan Makunga <makung@amazon.com> * Refactoring * Integration tests * Skip Alt Config integ tests as metadata aren't fully deployed. * Fix metric column name * Refactoring * Display API * Relax set deployment error handling * Override region for draft model data source * use latest boto3 * EBS Volue * model tags * UT * FIX UT --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Kalyani Nikure <110067132+knikure@users.noreply.github.com> Co-authored-by: Haotian An <33510317+Captainia@users.noreply.github.com> Co-authored-by: Jonathan Makunga <makung@amazon.com> Co-authored-by: evakravi <69981223+evakravi@users.noreply.github.com> Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com> Co-authored-by: Nikhil Kulkarni <knikhil29@gmail.com> Co-authored-by: Nikhil Kulkarni <nikhilsk@amazon.com> Co-authored-by: jessicazhu3 <106775307+jessicazhu3@users.noreply.github.com> Co-authored-by: Jessica Zhu <jessicazhu3@106775307+jessicazhu3@users.noreply.github.com> Co-authored-by: Justin <justinm088@hotmail.com> Co-authored-by: ASHWIN KRISHNA <38850354+akrishna1995@users.noreply.github.com> Co-authored-by: Ashwin Krishna <ashwikri@amazon.com> Co-authored-by: Haixin Wang <98612668+haixiw@users.noreply.github.com> Co-authored-by: Zhaoqi <52220743+zhaoqizqwang@users.noreply.github.com> Co-authored-by: Keerthan Vasist <kvasist@amazon.com> Co-authored-by: SuhitK <kodgule.suhit@gmail.com> Co-authored-by: Suhit Kodgule <skodgule@amazon.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: sagemaker-bot <sagemaker-bot@amazon.com> Co-authored-by: jiapinw <95885824+jiapinw@users.noreply.github.com> Co-authored-by: Prateek M Desai <prateekmdesai04@gmail.com> Co-authored-by: Ubuntu <ubuntu@ip-172-31-9-154.us-west-2.compute.internal> Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com> Co-authored-by: Samrudhi Sharma <154457034+samruds@users.noreply.github.com> Co-authored-by: Tom Bousso <tombousso@gmail.com> Co-authored-by: Zhaoqi <jzhaoqwa@amazon.com> Co-authored-by: Tyler Osterberg <tyoster@amazon.com> Co-authored-by: Jacky Lee <dr.jackylee@gmail.com> Co-authored-by: Jacky Lee <drjacky@amazon.com> Co-authored-by: Adam Kozdrowicz <akozdrowicz@gmail.com> Co-authored-by: bryannahm1 <110491182+bryannahm1@users.noreply.github.com> Co-authored-by: Bryannah Hernandez <brymh@amazon.com> Co-authored-by: Gokul A <166456257+nargokul@users.noreply.github.com> Co-authored-by: Jiao Liu <liujiaor@amazon.com> Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com> Co-authored-by: selvask-aws <selvask@amazon.com> Co-authored-by: adtian2 <55163384+adtian2@users.noreply.github.com> Co-authored-by: Andrew Tian <tinandr@amazon.com> Co-authored-by: ananth102 <abashyam@amazon.com> Co-authored-by: Malav Shastri <57682969+malav-shastri@users.noreply.github.com> Co-authored-by: Malav Shastri <malavhs@amazon.com> Co-authored-by: chrstfu <chrstfu@amazon.com> Co-authored-by: Siddharth Venkatesan <siddvenk@umich.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws/amazon-sagemaker-examples#4666
Description of changes:
Fixes issue with not using user-supplied instance type for
Estimator.deployTesting done:
Unit test added
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.