Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: estimator.deploy not respecting instance type #4724

Merged
merged 2 commits into from
Jun 10, 2024
Merged

fix: estimator.deploy not respecting instance type #4724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc84f20
fix: estimator.deploy not respecting instance type
evakravi Jun 10, 2024
f895afb
chore: add inline comment about using user supplied instance type
evakravi Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/sagemaker/jumpstart/factory/estimator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,12 @@ def get_deploy_kwargs(
model_id=model_id,
model_from_estimator=True,
model_version=model_version,
instance_type=model_deploy_kwargs.instance_type if training_instance_type is None else None,
instance_type=(
model_deploy_kwargs.instance_type
if training_instance_type is None
or instance_type is not None # always use supplied inference instance type
else None
),
region=region,
image_uri=image_uri,
source_dir=source_dir,
Expand Down
3 changes: 3 additions & 0 deletions tests/unit/sagemaker/jumpstart/estimator/test_estimator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1532,6 +1532,9 @@ def test_estimator_sets_different_inference_instance_depending_on_training_insta
estimator.deploy(image_uri="blah")
assert mock_estimator_deploy.call_args[1]["instance_type"] == "ml.p4de.24xlarge"

estimator.deploy(image_uri="blah", instance_type="ml.quantum.large")
assert mock_estimator_deploy.call_args[1]["instance_type"] == "ml.quantum.large"

@mock.patch("sagemaker.utils.sagemaker_timestamp")
@mock.patch("sagemaker.jumpstart.estimator.validate_model_id_and_get_type")
@mock.patch(
Expand Down