-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hover support for resource paths #41773
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #41773 +/- ##
============================================
- Coverage 76.71% 76.67% -0.04%
- Complexity 52734 53010 +276
============================================
Files 2878 2883 +5
Lines 198735 199902 +1167
Branches 25832 26018 +186
============================================
+ Hits 152453 153278 +825
- Misses 37869 38160 +291
- Partials 8413 8464 +51 ☔ View full report in Codecov by Sentry. |
...rver/modules/langserver-core/src/main/java/org/ballerinalang/langserver/hover/HoverUtil.java
Outdated
Show resolved
Hide resolved
...es/langserver-core/src/main/java/org/ballerinalang/langserver/hover/HoverObjectResolver.java
Outdated
Show resolved
Hide resolved
...rver/modules/langserver-core/src/main/java/org/ballerinalang/langserver/hover/HoverUtil.java
Outdated
Show resolved
Hide resolved
...es/langserver-core/src/main/java/org/ballerinalang/langserver/hover/HoverObjectResolver.java
Outdated
Show resolved
Hide resolved
|
First two have been addressed with #fde9bfb |
When documentation for a rest parameter is not provided (for a functional argument), it displays client class MyClient {
# Description.
#
# + param - parameter description
resource function accessor path(string param, int... ids) {
}
}
public function main() {
MyClient MyClient = new;
MyClient->/path.accessor("test", 1, 2, 3);
}
This is not specific to a resource access and occurs in function call expressions, as shown in the example below. The issue is tracked with: #41896 # Description.
#
# + param - parameter description
# + return - return value description
function name(string param, int... ids) returns string {
return "hello";
};
public function main() {
_ = name("hello", 1, 2, 3);
} |
...es/langserver-core/src/main/java/org/ballerinalang/langserver/hover/HoverObjectResolver.java
Outdated
Show resolved
Hide resolved
...es/langserver-core/src/main/java/org/ballerinalang/langserver/hover/HoverObjectResolver.java
Outdated
Show resolved
Hide resolved
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
b5a4134
into
ballerina-platform:master
Purpose
$title
Fixes #41646, #41896
Samples
Check List