Use Builder Pattern for HsmKeyParams #155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garw
requested changes
Oct 30, 2023
src/mococrw/hsm.h
Outdated
| public: | ||
| class Builder; | ||
|
|
||
| bool isExtractable() const { return cka_extractable; } |
There was a problem hiding this comment.
Do we really want to expose PKCS#11 slang here? Wouldn't it be better if this provides some Abstraction and we say here that the param is that the is is extractable or not? Sensitive is really not self-explanatory.
src/hsm.cpp
Outdated
| @@ -233,7 +234,8 @@ openssl::SSL_EVP_PKEY_Ptr HsmEngine::generateKey(const ECCSpec &spec, | |||
| const std::string &keyLabel, | |||
| const std::vector<uint8_t> &keyID) | |||
| { | |||
| HsmKeyParams hsmKeyParams; | |||
| HsmKeyParams hsmKeyParams = | |||
| HsmKeyParams::Builder().setCkaExtractable(false).setCkaSensitive(true).build(); | |||
There was a problem hiding this comment.
Style: Most of the library uses {} for object construction.
garw
previously requested changes
Oct 31, 2023
|
Merging in PR #156 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt the HsmKeyParams to use a Builder Pattern instead of a struct