Use Builder Pattern for HsmKeyParams #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istepic
reviewed
Nov 9, 2023
| @@ -261,8 +261,9 @@ openssl::SSL_EVP_PKEY_Ptr HsmEngine::generateKey(const ECCSpec &spec, | |||
| pkcs11ECCSpec.curve = curve.c_str(); | |||
|
|
|||
| PKCS11_params _params; | |||
| _params.extractable = static_cast<unsigned char>(params.cka_extractable); | |||
| _params.sensitive = static_cast<unsigned char>(params.cka_sensitive); | |||
| // If the key is extractable it shouldn't be sensitive and vice versa | |||
There was a problem hiding this comment.
I guess this makes sense in principle but is there a strong reason why do we want to enforce it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt the HsmKeyParams to use a Builder Pattern instead of a struct