feat(cloud): allow Number and Boolean custom properties #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marstamm
requested review from
philippfromme and
barmac
and removed request for
a team
marstamm
force-pushed
the
support-number-boolean
branch
from
e3beba1 to
bcefaa1
Compare
|
I think it would make sense to also implement the FEEL expression shortcut that we support for text fields, i.e. |
barmac
reviewed
Feb 13, 2024
Comment on lines
33
to
40
| const validate = useCallback((value) => { | ||
| if (isNumber(value) && value.toString().includes('e')) { | ||
| return translate('Scientific Notation is disallowed'); | ||
| } | ||
|
|
||
| const defaultValidator = propertyValidator(translate, property); | ||
| return defaultValidator(value); | ||
| }, [ translate, property ]); |
There was a problem hiding this comment.
I thought initially that it doesn't work as supposed because the automatic conversion (which I love) kicked in:
Screen.Recording.2024-02-13.at.11.54.32.mov
barmac
reviewed
Feb 13, 2024
src/cloud-element-templates/properties-panel/properties/CustomProperties/NumberProperty.js
Outdated
Show resolved
Hide resolved
I think that makes sense, but is not directly related to the element template feature. I created a follow-up issue in the properties-panel repo: bpmn-io/properties-panel#346 |
nikku
reviewed
Feb 16, 2024
src/cloud-element-templates/properties-panel/properties/CustomProperties/BooleanProperty.js
Outdated
Show resolved
Hide resolved
nikku
reviewed
Feb 16, 2024
src/cloud-element-templates/properties-panel/properties/CustomProperties/index.js
Outdated
Show resolved
Hide resolved
marstamm
force-pushed
the
support-number-boolean
branch
from
a2ad510 to
0105490
Compare
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to camunda/camunda-modeler#3622
Try it out with the "Number and Boolean" example template in the
npm startpreview environment.feel: optionalorfeel: staticis set in the templateOther Refactorings