Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip test which requires to be executed from an institutional account #253

Merged
merged 3 commits into from
Jul 20, 2024

Conversation

btschwertfeger
Copy link
Owner

@btschwertfeger btschwertfeger commented Jul 20, 2024

One test now fails since it must be executed from an institutional account. Since it is not scope off this SDK to check all that cases, we simply skip this test.

@btschwertfeger btschwertfeger self-assigned this Jul 20, 2024
@btschwertfeger btschwertfeger changed the title Loosen the harden-runner rules Skip test which requires to be executed from an institutional account Jul 20, 2024
@btschwertfeger btschwertfeger marked this pull request as ready for review July 20, 2024 12:18
Copy link

codecov bot commented Jul 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.90%. Comparing base (3cd3dbc) to head (c55736e).
Report is 39 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
- Coverage   86.95%   86.90%   -0.05%     
==========================================
  Files          25       25              
  Lines        2055     2055              
==========================================
- Hits         1787     1786       -1     
- Misses        268      269       +1     
Flag Coverage Δ
unittests 86.90% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@btschwertfeger btschwertfeger merged commit 8fb135b into master Jul 20, 2024
41 checks passed
@btschwertfeger btschwertfeger deleted the adjust-failing-tests branch July 20, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant